Add option to preserve user added layers when switching base maps

[chriszrc]

No description provided.

[el]

Hi, thank you for the PR. Can you please revert all unrelated changes like style changes?

[chriszrc]

@el hmm, I'm guessing you mean the auto formatting by prettier? I would probably suggest you consider using prettier since it's becoming the de facto formatting option-

[el]

You can create that as a separate pr. I am not against using a prettier. It just makes it hard to review the pr.

[vcardins]

@chriszrc Thanks for the initiative. Also, could you add an option to add a unique id for the style option button:

export type MapboxStyleDefinition = {
  id: string;
  title: string;
  uri: string | Style;
};

<button type="button" class="Satellite active" id="satellite" data-uri=""mapbox://styles/mapbox/satellite-v9"">Satellite

Thank you!!

[el]

@chriszrc Thanks for the initiative. Also, could you add an option to add a unique id for the style option button:

export type MapboxStyleDefinition = {
  id: string;
  title: string;
  uri: string | Style;
};

<button type="button" class="Satellite active" id="satellite" data-uri=""mapbox://styles/mapbox/satellite-v9"">Satellite

Thank you!!

What is the use case for this?

[vcardins]

For automated testing purposes

[mmc1718]

This looks really useful. Is it ready to merge?

[arthurjgs]

Hi, can you merge this if there is no conflict ?

[vcardins]

@el Could you update the status of this PR?

[el]

Unfortunately, the PR has used a prettier making all the code changes. Which makes it extremely hard to review. I asked the PR author to create a separate PR for prettier and only make the changes necessary in this PR but didn't hear back.

[vcardins]

Unfortunately, the PR has used a prettier making all the code changes. Which makes it extremely hard to review. I asked the PR author to create a separate PR for prettier and only make the changes necessary in this PR but didn't hear back.

It makes sense. I'm going to submit a PR with only the necessary changes.

[beniaminrychter]

Hello guys, any updates on that? 😊
This PR would be very helpful.

cc @vcardins