-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more fuzz tests #667
Comments
@dasoya - regarding your GSoC proposal, would you be up for writing a short introductory PR so we can get to know you better? |
Dear Emmett Lalish,
Thank you for considering my proposal.
I am passionate about working in the entertainment industry, such as
digital fashion using computer graphics. During my internship with NCsoft's
Digital Human team, I utilized C++ in Unreal Engine and TensorFlow to
develop 3D modeling AI. I developed games and had the opportunity to be a
PM and lead the release. My strength is that I take responsibility and get
things done. My technical skills include implementing ray tracing using C++
based on OpenGL. I have a strong interest in the technology that Manifold
implements and am willing to make improvements where needed.
Thank you for your consideration,
Kind regards
Daso Jung.
2024년 4월 17일 (수) 오전 2:13, Emmett Lalish ***@***.***>님이 작성:
… @dasoya <https://github.com/dasoya> - regarding your GSoC proposal, would
you be up for writing a short introductory PR so we can get to know you
better?
—
Reply to this email directly, view it on GitHub
<#667 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP2YNTCEAFUHL3JQH7TVTBLY5VL45AVCNFSM6AAAAABA4RUDBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJZGU3DKMJZHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@dasoya That's wonderful, and we'd certainly appreciate your contributions! From the GSoC side, they're much more willing to accept those who have demonstrated successful contribution to the code base. If you'd be willing to open a simple PR we can review and merge, it'll go a long way. If you're not sure where to start, a simple task we've been meaning to get around to is splitting our tests into more files - there are so many now that the granularity is much too coarse. If you'd like to take a stab at organizing some of them a bit, we'd certainly appreciate it. |
Thank you for your suggestion. I’ll try to contribute to the code base!
Daso Jung
…On Thu 18. Apr 2024 at 00:53, Emmett Lalish ***@***.***> wrote:
@dasoya <https://github.com/dasoya> That's wonderful, and we'd certainly
appreciate your contributions! From the GSoC side, they're much more
willing to accept those who have demonstrated successful contribution to
the code base. If you'd be willing to open a simple PR we can review and
merge, it'll go a long way. If you're not sure where to start, a simple
task we've been meaning to get around to is splitting our tests into more
files - there are so many now that the granularity is much too coarse. If
you'd like to take a stab at organizing some of them a bit, we'd certainly
appreciate it.
—
Reply to this email directly, view it on GitHub
<#667 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP2YNTHP4TAQ633DPXTGIPTY52LGJAVCNFSM6AAAAABA4RUDBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGYZDMNRTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@elalish As you suggested, I thought boolean_test.cpp has high complexity, so I divided it into two files. master...dasoya:manifold:boolean_fuzz Is this the right way? Let me know what you think. |
Yes, that's a great start - go ahead and open a PR. It's always best to have many, smaller PRs anyway, and it gives us a good place to discuss. |
We only have tests for the triangulator, and the test is only checking for segfault/memory corruption and infinite loops. We should add more tests.
CSG can be fuzzed with a simple grammar.
The text was updated successfully, but these errors were encountered: