-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split boolean tests #792
Split boolean tests #792
Conversation
dasoya
commented
Apr 23, 2024
- split boolean tests
- plan to implement more fuzz tests #667 / Add fuzzing tests opencax/GSoC#83
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I don't think there's any need to mark this as Draft - we can merge this pretty soon with couple small tweaks. Draft PRs also don't run our full CI checks.
There's a CLA issue because of author's email. I rebased it to change author. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #792 +/- ##
==========================================
- Coverage 91.84% 88.51% -3.33%
==========================================
Files 37 57 +20
Lines 4976 8098 +3122
Branches 0 874 +874
==========================================
+ Hits 4570 7168 +2598
- Misses 406 930 +524 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Now we just need to do this to manifold_test, which has also grown unreasonably.