Generate and install a version header alongside manifold headers. #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
force-pushed
the
feature-20241116-add-version-header
branch
from
00383a9 to
a41ca20
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1052 +/- ##
==========================================
- Coverage 91.84% 84.69% -7.15%
==========================================
Files 37 62 +25
Lines 4976 9685 +4709
Branches 0 1050 +1050
==========================================
+ Hits 4570 8203 +3633
- Misses 406 1482 +1076 ☔ View full report in Codecov by Sentry. |
elalish
reviewed
Nov 17, 2024
hzeller
force-pushed
the
feature-20241116-add-version-header
branch
from
a41ca20 to
49e5aef
Compare
elalish
approved these changes
Nov 17, 2024
There was a problem hiding this comment.
LGTM, thanks. @pca006132 I'll let you decide if you want to merge this before or after #1048.
|
What about just integrate it into #1048? This is not complicated. |
|
Sounds good to me - it is your pull request, so you need to integrate that. |
pca006132
added a commit
to pca006132/manifold
that referenced
this pull request
Nov 17, 2024
elalish
added a commit
that referenced
this pull request
Nov 17, 2024
* enable emscripten build with tbb enabled * nix: fix emscripten build, add tbb build * browser * fix python build * minor * no parallel sdf for js * disable test for emscripten-tbb * add cache for nix python build * cmake changes * fix * update * update * update * update * move python dependency handling * more changes * format * fix broken format * fix * simplify * allow emscripten with cbind * build fetched dependencies as static libs * fix static build * fix rebuild * fix extras * remove parallel.h from public API * update tests * make dependencies private * move parallel.h * missing utils.h change * fix * fix... * fix wasm tbb * add more cmake consumer tests * fix consumer * add rpath * Revert "add rpath" This reverts commit 2e8a96c. * rpath specific to macos * use override * forgot to set rpath... * remove #1045 related changes * integrate #1052 * allow version override * minor improvements * msvc changes * fix typo --------- Co-authored-by: Emmett Lalish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for a version header as suggested in #1024 (comment)
(probably to be merged after #1048 to not generate merge issues there.
FYI @kintel @pca006132