Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messages for dialogs #854

Merged
merged 7 commits into from
Dec 15, 2023
Merged

Messages for dialogs #854

merged 7 commits into from
Dec 15, 2023

Conversation

ssrahn
Copy link
Collaborator

@ssrahn ssrahn commented Dec 8, 2023

#833

  • Messages haben neues attribute {dialog: Boolean}
  • MessageList hat neues prop {dialog: Boolean}
  • Wenn dialog gesetzt, werden in MessageList nur Messages mit dialog attribute angezeigt
  • Sobald eine Dialog-MessageList schließt, werden alle Dialog-Messages gelöscht
  • So haben Dialoge eigene Messages und Fehlermeldungen, der Hintergrund bleibt damit sauber
  • Error die im front end abgefangen werden könnten, sollten jetzt nur noch Messages vom typen 'error' schmeißen
  • Die Error-Komponente ist immer noch Global! und fängt momentan nur Fehler von außerhalb ab (hier: app.js:49)

@ssrahn ssrahn requested a review from tgloeggl December 8, 2023 08:47
@ssrahn ssrahn self-assigned this Dec 8, 2023
@ssrahn ssrahn added v:3 Everything related to the Stud.IP Opencast Plugin Version 3.x type:usability labels Dec 8, 2023
@github-actions GitHub Actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@ssrahn ssrahn requested a review from tgloeggl December 12, 2023 00:00
@ssrahn
Copy link
Collaborator Author

ssrahn commented Dec 14, 2023

Übersetzungen

@github-actions GitHub Actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@tgloeggl tgloeggl merged commit 9919097 into master Dec 15, 2023
3 checks passed
@tgloeggl tgloeggl deleted the fix833 branch December 15, 2023 09:13
@tgloeggl tgloeggl mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgloeggl tgloeggl tgloeggl approved these changes

Assignees

@ssrahn ssrahn

Labels
type:usability v:3 Everything related to the Stud.IP Opencast Plugin Version 3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssrahn @tgloeggl