-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define value for all constant_keyword fields in apmpackage #12219
Conversation
This pull request does not have a backport label. Could you fix it @carsonip? 🙏
NOTE: |
7e88ed6
to
5dfe45a
Compare
This pull request is now in conflicts. Could you fix it @carsonip? 🙏
|
@simitt now that apmpackage no longer lives in apm-server repo, should I split this PR into 2 parts, 1 targeting apm-server 8.12 branch, another changing https://github.com/elastic/integrations/tree/main/packages/apm/data_stream ? |
Yeah I fear we need to put this into both places now unfortunately. |
6747d45
to
b204358
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this is merged I'll port the change to https://github.com/elastic/integrations/tree/main/packages/apm
run docs-build |
This change did not go into 8.12.1. Now the plan is to land this fix in 8.12.2. |
Port apm constant keyword fix from 8.12: elastic/apm-server#12219
The fix did not go into 8.12.1 due to automation issues. See elastic#12219
The fix did not go into 8.12.1 due to automation issues. See #12219
#12697) The fix did not go into 8.12.1 due to automation issues. See #12219 (cherry picked from commit 405663f) Co-authored-by: Carson Ip <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
#12698) The fix did not go into 8.12.1 due to automation issues. See #12219 (cherry picked from commit 405663f) Co-authored-by: Carson Ip <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
testing notes✔️ test-plan-ok In 8.12.2, in component template
the value of constant keyword is now set. |
testing notesUpgraded from a 8.12.1 deployment with existing data in metrics-apm.service_destination.1m-default etc to 8.12.2. Upgrade went well and data streams rolled over successfully. |
Motivation/summary
Define value for all
constant_keyword
fields in apmpackage to workaround Fleet upgrade bug. Under certain conditions, it is possible that apmpackage upgrade creates a lot of indices if constant_keyword does not have a value.Targeting 8.12 branch because apmpackage has been moved to https://github.com/elastic/integrations/tree/main/packages/apm/data_stream on main.
Checklist
apmpackage
have been made)For functional changes, consider:
How to test these changes
Related issues
Closes #12159