Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump go to 1.22 #12835

Merged
merged 7 commits into from
Mar 25, 2024
Merged

build: bump go to 1.22 #12835

merged 7 commits into from
Mar 25, 2024

Conversation

kruskall
Copy link
Member

Motivation/summary

Bump go version to 1.22

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Closes #12792

@kruskall kruskall requested a review from a team as a code owner March 21, 2024 13:31
Copy link
Contributor

mergify bot commented Mar 21, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Mar 21, 2024
@kruskall kruskall enabled auto-merge (squash) March 21, 2024 13:33
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kruskall
Copy link
Member Author

Is https://github.com/elastic/apm-server/blob/main/.go-version also required to be updated?

Good catch! Updated!

v1v
v1v previously approved these changes Mar 22, 2024
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! My comment for 1.22.1 is not a blocker, updatecli will run and bump the 1.22 patch versions.

.go-version Outdated Show resolved Hide resolved
@kruskall kruskall merged commit 6f7d4b7 into elastic:main Mar 25, 2024
12 checks passed
@kruskall kruskall deleted the feat/go1.22 branch March 25, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants