Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: cleanup go.mk and make tasks #13421

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

kruskall
Copy link
Member

Motivation/summary

GO is just an alias for go now and we use the tools go.mod to run the tool instead of using go build.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Followup from #13415 (comment)

GO is just an alias for go now and we use the tools go.mod to run the tool
instead of using go build.
@kruskall kruskall requested a review from a team as a code owner June 17, 2024 12:10
Copy link
Contributor

mergify bot commented Jun 17, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jun 17, 2024
@kruskall kruskall enabled auto-merge (squash) June 18, 2024 00:44
@kruskall kruskall merged commit 7dd02aa into elastic:main Jun 18, 2024
10 checks passed
@kruskall kruskall deleted the cleanup/go-mk branch June 18, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants