Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildkite: microbenchmarks pipeline using the repository name explicitly when using the gh cli wrapper #13422

Merged
merged 2 commits into from
Jun 17, 2024
Merged

buildkite: microbenchmarks pipeline using the repository name explicitly when using the gh cli wrapper #13422

merged 2 commits into from
Jun 17, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Jun 17, 2024

Motivation/summary

The Buildkite microbenchmarks pipeline is a pipeline helper used by the APM Agents and APM Server, therefore its repository context is not elastic/apm-server but an internal github repository.

Let's fix the name of the project in the Makefile so we ensure no errors are printed in the console output


GraphQL: Could not resolve to a Repository with the name 'elastic/observability-robots'. (repository)
--
  | go: downloading github.com/elastic/elastic-agent-libs v0.9.12
  | go: downloading go.opentelemetry.io/otel v1.27.0

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@v1v v1v added backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.14 Automated backport with mergify labels Jun 17, 2024
@v1v v1v requested a review from a team June 17, 2024 14:17
@v1v v1v self-assigned this Jun 17, 2024
@v1v v1v requested a review from a team as a code owner June 17, 2024 14:17
@kruskall kruskall enabled auto-merge (squash) June 17, 2024 20:15
@kruskall kruskall merged commit 9477e1e into elastic:main Jun 17, 2024
10 checks passed
@v1v v1v changed the title buildkite: microbenchmarks uses a context switch buildkite: microbenchmarks pipeline using the repository name explicitly when using the gh cli wrapper Jun 17, 2024
mergify bot pushed a commit that referenced this pull request Jun 17, 2024
@v1v @mergify
buildkite: microbenchmarks uses a context switch (#13422)
584d2a5 
(cherry picked from commit 9477e1e)
@mergify mergify bot mentioned this pull request Jun 17, 2024
Merged
2 tasks
mergify bot pushed a commit that referenced this pull request Jun 17, 2024
@v1v @mergify
buildkite: microbenchmarks uses a context switch (#13422)
6e8d4c9 
(cherry picked from commit 9477e1e)
@mergify mergify bot mentioned this pull request Jun 17, 2024
Merged
2 tasks
mergify bot added a commit that referenced this pull request Jun 17, 2024
@mergify @v1v
buildkite: microbenchmarks uses a context switch (#13422) (#13432)
bafbb9f 
(cherry picked from commit 9477e1e)

Co-authored-by: Victor Martinez <[email protected]>
mergify bot added a commit that referenced this pull request Jun 17, 2024
@mergify @v1v
buildkite: microbenchmarks uses a context switch (#13422) (#13431)
a1e96a5 
(cherry picked from commit 9477e1e)

Co-authored-by: Victor Martinez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruskall kruskall kruskall approved these changes

@1pkg 1pkg 1pkg approved these changes

Assignees

@v1v v1v

Labels
backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.14 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v1v @1pkg @kruskall