Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] terraform: add tags module (backport #15303) #15307

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 20, 2025

Motivation/summary

The current CI integration with the Terraform ec_deployment uses OIDC; hence, it uses the robots automation, but unfortunately, if ephemeral:true is not set and the tear-down steps fail in the CI, those resources are not deleted automatically but manually.

We want to enforce using ephemeral:true in all the Terraform resources using ec, the ephemeral:true was added as part of #14179

But I didn't see the tags to be set for the cloud and functional tests that run in the CI or can run.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues


This is an automatic backport of pull request #15303 done by [Mergify](https://mergify.com).

(cherry picked from commit 85719ef)
@mergify mergify bot requested a review from a team as a code owner January 20, 2025 17:52
@mergify mergify bot added the backport label Jan 20, 2025
@mergify mergify bot assigned v1v Jan 20, 2025
@mergify mergify bot merged commit 34db2b4 into 8.x Jan 20, 2025
16 checks passed
@mergify mergify bot deleted the mergify/bp/8.x/pr-15303 branch January 20, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants