-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asset Inventory POC structrue & EC2 Implementation #2010
Conversation
b955ea6
to
5013e03
Compare
This pull request does not have a backport label. Could you fix it @romulets? 🙏
|
📊 Allure Report - 💚 No failures were reported.
|
7930de4
to
14d57a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the design, left some questions and minor comments.
logger: logger, | ||
fetchers: fetchers, | ||
publisher: publisher, | ||
// move to a configuration parameter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a leftover TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jah, it's indeed. For the poc I decided to keep it here, I don't see a reason to make it an external configuration.
Do you disagree?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. Just making sure you haven't missed it by accident :)
14d57a4
to
a289194
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, my concerns were addressed
a289194
to
d43c12c
Compare
Summary of your changes
As part of testing some technical concepts for the Asset Inventory project a new cloudbeat flavour is being added to hold the Asset Inventory Proof of Concept.
This PR adds a new flavour and implements EC2 fetching
to remove the host data configure cloudbeat.yml with:
Screenshot/Data
Related Issues
Checklist