Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Inventory POC structrue & EC2 Implementation #2010

Merged
merged 11 commits into from
Mar 14, 2024

Conversation

romulets
Copy link
Member

@romulets romulets commented Mar 8, 2024

Summary of your changes

As part of testing some technical concepts for the Asset Inventory project a new cloudbeat flavour is being added to hold the Asset Inventory Proof of Concept.

This PR adds a new flavour and implements EC2 fetching

to remove the host data configure cloudbeat.yml with:

processors:
  - drop_fields:
      fields: ["host.name"]
#  - add_host_metadata: ~
#  - add_cloud_metadata : ~
#  - add_docker_metadata: ~

Screenshot/Data

image

Related Issues

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

@romulets romulets requested a review from a team as a code owner March 8, 2024 15:36
@romulets romulets force-pushed the asset_inventory_poc_ec2 branch from b955ea6 to 5013e03 Compare March 8, 2024 15:36
Copy link

mergify bot commented Mar 8, 2024

This pull request does not have a backport label. Could you fix it @romulets? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Mar 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 162
⬜ Skipped 0

@romulets romulets force-pushed the asset_inventory_poc_ec2 branch 5 times, most recently from 7930de4 to 14d57a4 Compare March 11, 2024 10:24
Copy link
Member

@kubasobon kubasobon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the design, left some questions and minor comments.

logger: logger,
fetchers: fetchers,
publisher: publisher,
// move to a configuration parameter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a leftover TODO

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jah, it's indeed. For the poc I decided to keep it here, I don't see a reason to make it an external configuration.

Do you disagree?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Just making sure you haven't missed it by accident :)

internal/inventory/asset.go Show resolved Hide resolved
internal/resources/utils/pointers/pointers.go Show resolved Hide resolved
internal/inventory/aws/fetcher_ec2.go Outdated Show resolved Hide resolved
internal/inventory/inventory.go Show resolved Hide resolved
@romulets romulets force-pushed the asset_inventory_poc_ec2 branch from 14d57a4 to a289194 Compare March 14, 2024 14:03
@romulets romulets requested a review from kubasobon March 14, 2024 14:03
Copy link
Member

@kubasobon kubasobon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, my concerns were addressed

@romulets romulets force-pushed the asset_inventory_poc_ec2 branch from a289194 to d43c12c Compare March 14, 2024 15:21
@romulets romulets enabled auto-merge (squash) March 14, 2024 15:23
@romulets romulets merged commit c69b413 into elastic:main Mar 14, 2024
26 of 27 checks passed
@romulets romulets deleted the asset_inventory_poc_ec2 branch March 14, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants