Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune container image fields to align with Otel SemConv #2282

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.next.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ Thanks, you're awesome :-) -->

#### Breaking changes

* Tune container image fields to align with Otel SemConv #2282

#### Bugfixes

#### Added
Expand Down
23 changes: 21 additions & 2 deletions docs/fields/field-details.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -1119,8 +1119,27 @@ type: keyword
// ===============================================================

|
[[field-container-image-tag]]
<<field-container-image-tag, container.image.tag>>
[[field-container-image-repo-digests]]
<<field-container-image-repo-digests, container.image.repo_digests>>

a| [Docker](https://docs.docker.com/engine/api/v1.43/#tag/Image/operation/ImageInspect) and [CRI](https://github.com/kubernetes/cri-api/blob/c75ef5b473bbe2d0a4fc92f82235efd665ea8e9f/pkg/apis/runtime/v1/api.proto#L1237-L1238) report those under the `RepoDigests` field.

type: keyword


Note: this field should contain an array of values.



example: `[example@sha256:afcc7f1ac1b49db317a7196c902e61c6c3c4607d63599ee1a82d702d249a0ccb]`

| extended

// ===============================================================

|
[[field-container-image-tags]]
<<field-container-image-tags, container.image.tags>>

a| Container image tags.

Expand Down
12 changes: 11 additions & 1 deletion experimental/generated/beats/fields.ecs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -799,11 +799,21 @@
type: keyword
ignore_above: 1024
description: Name of the image the container was built on.
- name: image.tag
- name: image.repo_digests
level: extended
type: keyword
ignore_above: 1024
description: '[Docker](https://docs.docker.com/engine/api/v1.43/#tag/Image/operation/ImageInspect)
and [CRI](https://github.com/kubernetes/cri-api/blob/c75ef5b473bbe2d0a4fc92f82235efd665ea8e9f/pkg/apis/runtime/v1/api.proto#L1237-L1238)
report those under the `RepoDigests` field.'
example: '[example@sha256:afcc7f1ac1b49db317a7196c902e61c6c3c4607d63599ee1a82d702d249a0ccb]'
default_field: false
- name: image.tags
level: extended
type: keyword
ignore_above: 1024
description: Container image tags.
default_field: false
- name: labels
level: extended
type: object
Expand Down
3 changes: 2 additions & 1 deletion experimental/generated/csv/fields.csv
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@ ECS_Version,Indexed,Field_Set,Field,Type,Level,Normalization,Example,Description
8.11.0-dev+exp,true,container,container.id,keyword,core,,,Unique container id.
8.11.0-dev+exp,true,container,container.image.hash.all,keyword,extended,array,[sha256:f8fefc80e3273dc756f288a63945820d6476ad64883892c771b5e2ece6bf1b26],An array of digests of the image the container was built on.
8.11.0-dev+exp,true,container,container.image.name,keyword,extended,,,Name of the image the container was built on.
8.11.0-dev+exp,true,container,container.image.tag,keyword,extended,array,,Container image tags.
8.11.0-dev+exp,true,container,container.image.repo_digests,keyword,extended,array,[example@sha256:afcc7f1ac1b49db317a7196c902e61c6c3c4607d63599ee1a82d702d249a0ccb],Repo digests of the container image as provided by the container runtime.
8.11.0-dev+exp,true,container,container.image.tags,keyword,extended,array,,Container image tags.
8.11.0-dev+exp,true,container,container.labels,object,extended,,,Image labels.
8.11.0-dev+exp,true,container,container.memory.usage,scaled_float,extended,,,"Percent memory used, between 0 and 1."
8.11.0-dev+exp,true,container,container.name,keyword,extended,,,Container name.
Expand Down
22 changes: 18 additions & 4 deletions experimental/generated/ecs/ecs_flat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1121,13 +1121,27 @@ container.image.name:
normalize: []
short: Name of the image the container was built on.
type: keyword
container.image.tag:
dashed_name: container-image-tag
container.image.repo_digests:
dashed_name: container-image-repo-digests
description: '[Docker](https://docs.docker.com/engine/api/v1.43/#tag/Image/operation/ImageInspect)
and [CRI](https://github.com/kubernetes/cri-api/blob/c75ef5b473bbe2d0a4fc92f82235efd665ea8e9f/pkg/apis/runtime/v1/api.proto#L1237-L1238)
report those under the `RepoDigests` field.'
example: '[example@sha256:afcc7f1ac1b49db317a7196c902e61c6c3c4607d63599ee1a82d702d249a0ccb]'
flat_name: container.image.repo_digests
ignore_above: 1024
level: extended
name: image.repo_digests
normalize:
- array
short: Repo digests of the container image as provided by the container runtime.
type: keyword
container.image.tags:
dashed_name: container-image-tags
description: Container image tags.
flat_name: container.image.tag
flat_name: container.image.tags
ignore_above: 1024
level: extended
name: image.tag
name: image.tags
normalize:
- array
short: Container image tags.
Expand Down
22 changes: 18 additions & 4 deletions experimental/generated/ecs/ecs_nested.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1500,13 +1500,27 @@ container:
normalize: []
short: Name of the image the container was built on.
type: keyword
container.image.tag:
dashed_name: container-image-tag
container.image.repo_digests:
dashed_name: container-image-repo-digests
description: '[Docker](https://docs.docker.com/engine/api/v1.43/#tag/Image/operation/ImageInspect)
and [CRI](https://github.com/kubernetes/cri-api/blob/c75ef5b473bbe2d0a4fc92f82235efd665ea8e9f/pkg/apis/runtime/v1/api.proto#L1237-L1238)
report those under the `RepoDigests` field.'
example: '[example@sha256:afcc7f1ac1b49db317a7196c902e61c6c3c4607d63599ee1a82d702d249a0ccb]'
flat_name: container.image.repo_digests
ignore_above: 1024
level: extended
name: image.repo_digests
normalize:
- array
short: Repo digests of the container image as provided by the container runtime.
type: keyword
container.image.tags:
dashed_name: container-image-tags
description: Container image tags.
flat_name: container.image.tag
flat_name: container.image.tags
ignore_above: 1024
level: extended
name: image.tag
name: image.tags
normalize:
- array
short: Container image tags.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,11 @@
"ignore_above": 1024,
"type": "keyword"
},
"tag": {
"repo_digests": {
"ignore_above": 1024,
"type": "keyword"
},
"tags": {
"ignore_above": 1024,
"type": "keyword"
}
Expand Down
6 changes: 5 additions & 1 deletion experimental/generated/elasticsearch/legacy/template.json
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,11 @@
"ignore_above": 1024,
"type": "keyword"
},
"tag": {
"repo_digests": {
"ignore_above": 1024,
"type": "keyword"
},
"tags": {
"ignore_above": 1024,
"type": "keyword"
}
Expand Down
12 changes: 11 additions & 1 deletion generated/beats/fields.ecs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -749,11 +749,21 @@
type: keyword
ignore_above: 1024
description: Name of the image the container was built on.
- name: image.tag
- name: image.repo_digests
level: extended
type: keyword
ignore_above: 1024
description: '[Docker](https://docs.docker.com/engine/api/v1.43/#tag/Image/operation/ImageInspect)
and [CRI](https://github.com/kubernetes/cri-api/blob/c75ef5b473bbe2d0a4fc92f82235efd665ea8e9f/pkg/apis/runtime/v1/api.proto#L1237-L1238)
report those under the `RepoDigests` field.'
example: '[example@sha256:afcc7f1ac1b49db317a7196c902e61c6c3c4607d63599ee1a82d702d249a0ccb]'
default_field: false
- name: image.tags
level: extended
type: keyword
ignore_above: 1024
description: Container image tags.
default_field: false
- name: labels
level: extended
type: object
Expand Down
3 changes: 2 additions & 1 deletion generated/csv/fields.csv
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ ECS_Version,Indexed,Field_Set,Field,Type,Level,Normalization,Example,Description
8.11.0-dev,true,container,container.id,keyword,core,,,Unique container id.
8.11.0-dev,true,container,container.image.hash.all,keyword,extended,array,[sha256:f8fefc80e3273dc756f288a63945820d6476ad64883892c771b5e2ece6bf1b26],An array of digests of the image the container was built on.
8.11.0-dev,true,container,container.image.name,keyword,extended,,,Name of the image the container was built on.
8.11.0-dev,true,container,container.image.tag,keyword,extended,array,,Container image tags.
8.11.0-dev,true,container,container.image.repo_digests,keyword,extended,array,[example@sha256:afcc7f1ac1b49db317a7196c902e61c6c3c4607d63599ee1a82d702d249a0ccb],Repo digests of the container image as provided by the container runtime.
8.11.0-dev,true,container,container.image.tags,keyword,extended,array,,Container image tags.
8.11.0-dev,true,container,container.labels,object,extended,,,Image labels.
8.11.0-dev,true,container,container.memory.usage,scaled_float,extended,,,"Percent memory used, between 0 and 1."
8.11.0-dev,true,container,container.name,keyword,extended,,,Container name.
Expand Down
22 changes: 18 additions & 4 deletions generated/ecs/ecs_flat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1052,13 +1052,27 @@ container.image.name:
normalize: []
short: Name of the image the container was built on.
type: keyword
container.image.tag:
dashed_name: container-image-tag
container.image.repo_digests:
dashed_name: container-image-repo-digests
description: '[Docker](https://docs.docker.com/engine/api/v1.43/#tag/Image/operation/ImageInspect)
and [CRI](https://github.com/kubernetes/cri-api/blob/c75ef5b473bbe2d0a4fc92f82235efd665ea8e9f/pkg/apis/runtime/v1/api.proto#L1237-L1238)
report those under the `RepoDigests` field.'
example: '[example@sha256:afcc7f1ac1b49db317a7196c902e61c6c3c4607d63599ee1a82d702d249a0ccb]'
flat_name: container.image.repo_digests
ignore_above: 1024
level: extended
name: image.repo_digests
normalize:
- array
short: Repo digests of the container image as provided by the container runtime.
type: keyword
container.image.tags:
dashed_name: container-image-tags
description: Container image tags.
flat_name: container.image.tag
flat_name: container.image.tags
ignore_above: 1024
level: extended
name: image.tag
name: image.tags
normalize:
- array
short: Container image tags.
Expand Down
22 changes: 18 additions & 4 deletions generated/ecs/ecs_nested.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1420,13 +1420,27 @@ container:
normalize: []
short: Name of the image the container was built on.
type: keyword
container.image.tag:
dashed_name: container-image-tag
container.image.repo_digests:
dashed_name: container-image-repo-digests
description: '[Docker](https://docs.docker.com/engine/api/v1.43/#tag/Image/operation/ImageInspect)
and [CRI](https://github.com/kubernetes/cri-api/blob/c75ef5b473bbe2d0a4fc92f82235efd665ea8e9f/pkg/apis/runtime/v1/api.proto#L1237-L1238)
report those under the `RepoDigests` field.'
example: '[example@sha256:afcc7f1ac1b49db317a7196c902e61c6c3c4607d63599ee1a82d702d249a0ccb]'
flat_name: container.image.repo_digests
ignore_above: 1024
level: extended
name: image.repo_digests
normalize:
- array
short: Repo digests of the container image as provided by the container runtime.
type: keyword
container.image.tags:
dashed_name: container-image-tags
description: Container image tags.
flat_name: container.image.tag
flat_name: container.image.tags
ignore_above: 1024
level: extended
name: image.tag
name: image.tags
normalize:
- array
short: Container image tags.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,11 @@
"ignore_above": 1024,
"type": "keyword"
},
"tag": {
"repo_digests": {
"ignore_above": 1024,
"type": "keyword"
},
"tags": {
"ignore_above": 1024,
"type": "keyword"
}
Expand Down
6 changes: 5 additions & 1 deletion generated/elasticsearch/legacy/template.json
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,11 @@
"ignore_above": 1024,
"type": "keyword"
},
"tag": {
"repo_digests": {
"ignore_above": 1024,
"type": "keyword"
},
"tags": {
"ignore_above": 1024,
"type": "keyword"
}
Expand Down
14 changes: 13 additions & 1 deletion schemas/container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
description: >
Name of the image the container was built on.

- name: image.tag
- name: image.tags
level: extended
type: keyword
description: >
Expand All @@ -84,6 +84,18 @@
normalize:
- array

- name: image.repo_digests
level: extended
type: keyword
short: Repo digests of the container image as provided by the container runtime.
description: >
[Docker](https://docs.docker.com/engine/api/v1.43/#tag/Image/operation/ImageInspect) and
[CRI](https://github.com/kubernetes/cri-api/blob/c75ef5b473bbe2d0a4fc92f82235efd665ea8e9f/pkg/apis/runtime/v1/api.proto#L1237-L1238)
report those under the `RepoDigests` field.
example: '[example@sha256:afcc7f1ac1b49db317a7196c902e61c6c3c4607d63599ee1a82d702d249a0ccb]'
normalize:
- array

- name: labels
level: extended
type: object
Expand Down
Loading