-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for missing license headers #2378
base: main
Are you sure you want to change the base?
Conversation
Add `make check_license_headers` as a test workflow step, in order to detect any yaml or py files without the required license header.
https://github.com/marketplace/actions/license-eye-header You may want to use this ci task |
Would be also nice if you not just check for Licensed to Elasticsearch B.V. But also check fot the Apache License If its okay, i can do a pr with the ci Plugin. This way we can see this an an extra check in the pr |
Hi @stbischof, if you'd like to create another PR for this, I'd appreciate it |
Hi! We just realized that we haven't looked into this PR in a while. We're We're labeling this PR as Thank you for your contribution! |
@stbischof still my task |
Add
make check_license_headers
as a test workflow step, in order to detect any yaml or py files without the required license header.make test
? ymake
and committed those changes? n/a