-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add domain
to email.*
Fields
#2392
base: main
Are you sure you want to change the base?
Conversation
domain
to email.*
Fields
Hi! We just realized that we haven't looked into this PR in a while. We're We're labeling this PR as Thank you for your contribution! |
I would still like to see this implemented. |
@@ -16,6 +16,13 @@ Thanks, you're awesome :-) --> | |||
|
|||
#### Added | |||
|
|||
* Added `volume.*` as beta field set. #2269 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your changelog is outdated, we have released a new version since then
The domain of the email sender. | ||
example: "example.com" | ||
normalize: | ||
- array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why it’s an array?
The domain of the sender address. | ||
example: "example.com" | ||
normalize: | ||
- array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same question - why it’s an array
Could you please check https://github.com/elastic/ecs/blob/main/CONTRIBUTING.md and create all autogenerated files and docs? |
Also please note we are currently in the process of ECS donation to Open telemetry schema, so we are not accepting PRs without a proper introduction of the same fields into Otel. In simple or important cases we might though make an exception |
This PR is to add email.from.domain and email.to.domain to ECS. These changes will help to visualize and report on emails sent to/from a specific domain/company.