Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domain to email.* Fields #2392

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

MakoWish
Copy link

This PR is to add email.from.domain and email.to.domain to ECS. These changes will help to visualize and report on emails sent to/from a specific domain/company.

@MakoWish MakoWish marked this pull request as ready for review October 24, 2024 16:18
@MakoWish MakoWish requested a review from a team as a code owner October 24, 2024 16:18
@MakoWish MakoWish changed the title Add domain to email.to and email.from. Add domain to email.* Fields Oct 24, 2024
Copy link

Hi!

We just realized that we haven't looked into this PR in a while. We're
sorry!

We're labeling this PR as Stale to make it hit our filters and
make sure we get back to it as soon as possible. In the meantime, it'd
be extremely helpful if you could take a look at it as well and confirm its
relevance. A simple comment with a nice emoji will be enough :+1.

Thank you for your contribution!

@github-actions github-actions bot added the stale Stale issues and pull requests label Dec 24, 2024
@MakoWish
Copy link
Author

I would still like to see this implemented.

@@ -16,6 +16,13 @@ Thanks, you're awesome :-) -->

#### Added

* Added `volume.*` as beta field set. #2269
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your changelog is outdated, we have released a new version since then

The domain of the email sender.
example: "example.com"
normalize:
- array
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why it’s an array?

The domain of the sender address.
example: "example.com"
normalize:
- array
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same question - why it’s an array

@trisch-me
Copy link
Contributor

Could you please check https://github.com/elastic/ecs/blob/main/CONTRIBUTING.md and create all autogenerated files and docs?

@trisch-me
Copy link
Contributor

Also please note we are currently in the process of ECS donation to Open telemetry schema, so we are not accepting PRs without a proper introduction of the same fields into Otel. In simple or important cases we might though make an exception

@github-actions github-actions bot removed the stale Stale issues and pull requests label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "*.domain" Fields to ECS "email" Schema
2 participants