Update release versioning for snapshot releases #8389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utions don't break
…is dependency versions to `workspace:*` so they always point to exact versions needed
…egistry.yarnpkg.com
…imestamp-based preid increments (`1.2.3-snapshot.<timestamp>`) and skip committing the version changes
tkajtoch
commented
Mar 5, 2025
| @@ -32,7 +32,7 @@ | |||
| "@babel/preset-env": "^7.21.5", | |||
| "@babel/preset-react": "^7.18.6", | |||
| "@babel/preset-typescript": "^7.21.5", | |||
| "@elastic/eui-theme-common": "workspace:^", | |||
| "@elastic/eui-theme-common": "workspace:*", | |||
There was a problem hiding this comment.
This is needed so that yarn replaces it during packing to an exact version instead of compatible with (^) version
tkajtoch
commented
Mar 5, 2025
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@elastic/eui-theme-common", | |||
| "version": "0.0.9", | |||
| "version": "0.0.11", | |||
There was a problem hiding this comment.
The last eui-theme-common version update was not committed. I must've forgotten to include it when doing it manually.
tkajtoch
commented
Mar 5, 2025
|
|
||
| for (const workspace of workspaces) { | ||
| logger.debug(`Calculating changes in ${workspace.name}`); | ||
|
|
||
| const workspaceDir = path.join(rootWorkspaceDir, workspace.location); | ||
| const currentVersion = await getWorkspacePackageVersion(workspaceDir); | ||
|
|
||
| const { changelogMap, changelog, hasChanges, processedChangelogFiles } = | ||
| await collateChangelogFiles(workspaceDir); | ||
| if (options.type === 'snapshot') { |
There was a problem hiding this comment.
This could be done better and moved to separate functions but we can clean it up later
mgadewoll
approved these changes
Mar 5, 2025
|
Preview staging links for this PR:
|
💚 Build Succeeded
cc @tkajtoch |
weronikaolejniczak
pushed a commit
to weronikaolejniczak/eui
that referenced
this pull request
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the way snapshot releases (
yarn release snapshot) are versioned. Previously, bothofficialandsnapshotreleases used the regular changelog-based new version calculation. It wasn't correct since snapshot releases are meant for testing, and they should not use the same versioning scheme, even if suffixed with-snapshot.The updated code builds and publishes packages with a timestamp-based versioning, for example:
99.4.0->99.4.0-snapshot.17411231624161.2.3-borealis.0->1.2.3-snapshot.1741123163100With this change, the updated
package.jsonversions will not be committed. Keep in mind, though, that the file is still edited, and will be marked as modified by git. There's no reset logic to get them back to the original state yet but it may be implemented in near future.QA
npm logoutandyarn npm logoutgh pr checkout <id>docker run -it --rm --name verdaccio -p 4873:4873 verdaccio/verdaccioand login as withyarn npm login(enter the same user/password pair as previously, e.g.test/test).yarnrcto use the custom local verdaccio registryyarnyarn workspace @elastic/eui-release-cli run build(this will be automated soon)yarn release run snapshot --allow-custom --workspaces @elastic/eui-theme-common @elastic/eui-theme-borealis @elastic/euiand follow its instructions<version>-snapshot.<timestamp>versions on http://localhost:4873