Improve OpenBSD memory handling #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the types are packed correctly and we don't end up with a silent 0 for npages for example. closes #12
mndrix
reviewed
Jun 30, 2017
| @@ -282,7 +292,7 @@ func (self *Swap) Get() error { | |||
|
|
|||
| rnswap := C.swapctl(C.SWAP_STATS, unsafe.Pointer(&swdev[0]), nswap) | |||
| if rnswap == 0 { | |||
| return nil | |||
| return fmt.Errorf("Failed to call swapctl(2)") | |||
There was a problem hiding this comment.
Will this return an error when a machine has 0 swap devices? The OpenBSD man page for swapctl(2) is somewhat ambiguous here, but my interpretation is that a return value of 0 is OK and -1 indicates failure.
There was a problem hiding this comment.
It won't return an error in such case; I've ran swapctl -d /dev/sd0b to remove my /dev/sd0b as a swap device and this conditional didn't get triggered.
❕ Build Aborted
Expand to view the summary
Build stats
Trends 🧪Steps errors
Expand to view the steps failures
|
❕ Build Aborted
Expand to view the summary
Build stats
Trends 🧪Steps errors
Expand to view the steps failures
|
❕ Build Aborted
Expand to view the summary
Build stats
Trends 🧪Steps errors
Expand to view the steps failures
|
❕ Build Aborted
Expand to view the summary
Build stats
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As prompted by #72, the actual fix and some improvements in error reporting.
NB: This was tested with
examples/free/free.go, not cockroachdb itself.