-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add weekly job to test packages with Ubuntu Elastic Agent docker image #10844
[CI] Add weekly job to test packages with Ubuntu Elastic Agent docker image #10844
Conversation
/test |
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
audit |
3322.26 | 2293.58 | -1028.68 (-30.96%) | 💔 |
cloud_configuration_finding |
4651.16 | 3174.6 | -1476.56 (-31.75%) | 💔 |
To see the full report comment with /test benchmark fullreport
/test |
kind: file | ||
sourceid: latestSnapshotMajorMinor | ||
scmid: default | ||
spec: | ||
file: '.buildkite/pipeline.schedule-daily.yml' | ||
matchpattern: '(Stack Version) v8\.\d+"' | ||
replacepattern: 'Stack Version v{{ source "latestSnapshotMajorMinor" }}"' | ||
|
||
## TODO: Looks like these targets are running with the contents from main branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be uncommented in a following PR.
schedules: | ||
main_weekly: | ||
branch: "main" | ||
cronline: "30 3 * * 1" | ||
message: "Run the weekly jobs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be commented until the wolfi is used ? or should we already running this job weekly ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should already run this weekly to capture any early bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pipeline will run the system tests using the Ubuntu Elastic Agent docker image. So it would be running for now the same tests as the daily builds.
This will change once the upcoming elastic-package release is merged into this repository. From there, packages will be tested with the wolfi images in the daily builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I guess we can wait, but it would be good to have it running at least once before wolfi images are available, to have a base to compare with. Though the dailies can be this base too.
Split this PR into two. This PR will add the new CI pipeline, and this other PR #10885 will add the support needed to test with different docker images. Updated the description of this PR accordingly. |
.github/workflows/updatecli/updatecli.d/bump-latest-snapshot-version.yml
Outdated
Show resolved
Hide resolved
.github/workflows/updatecli/updatecli.d/bump-latest-snapshot-version.yml
Outdated
Show resolved
Hide resolved
kind: file | ||
sourceid: latestSnapshotMajorMinor | ||
scmid: default | ||
spec: | ||
file: '.buildkite/pipeline.schedule-daily.yml' | ||
matchpattern: '(Stack Version) v8\.\d+"' | ||
replacepattern: 'Stack Version v{{ source "latestSnapshotMajorMinor" }}"' | ||
|
||
## TODO: Looks like these targets are running with the contents from main branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm, it is configured to trigger also on pull requests and I remember it took the changes 🤔
pull_request: |
But maybe this only works for existing targets? Or for branches pushed to upstream repository?
Or it could be related to the conflicting names, now they are duplicated as mentioned in other comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or it could be related to the conflicting names, now they are duplicated as mentioned in other comments.
When I was testing this, the names where update-snapshot
and update-snapshot-weekly-build
deeb675
For that commit, that this line exists in main branch the github action was working successfully. The other commits where the expected line did not exist yet in main branch, github actions were failing.
Maybe it is related to not create the branch in the upstream repository, I did not test that.
schedules: | ||
main_weekly: | ||
branch: "main" | ||
cronline: "30 3 * * 1" | ||
message: "Run the weekly jobs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I guess we can wait, but it would be good to have it running at least once before wolfi images are available, to have a base to compare with. Though the dailies can be this base too.
Co-authored-by: Jaime Soriano Pastor <[email protected]>
⏳ Build in-progress, with failures
Failed CI StepsHistory
cc @mrodm |
Quality Gate passedIssues Measures |
Proposed commit message
This PR adds a new CI pipeline that runs once per week. Builds from this pipeline will run the tests with the Ubuntu Elastic Agent docker image.
Added the environment variable to prepare for the upcoming elastic-package release. That environment variable is added in elastic/elastic-package#2038
Checklist
[ ] I have verified that all data streams collect metrics or logs.[ ] I have added an entry to my package'schangelog.yml
file.[ ] I have verified that Kibana version constraints are current according to guidelines.Author's Checklist
elastic-package
replacement in go.mod.[x] Test Elastic Agent docker image override in stack and tests.Related issues