Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to filter out managed pipelines in Stack Management > Ingest Pipelines #154621

Closed
wants to merge 19 commits into from
Closed

Add an option to filter out managed pipelines in Stack Management > Ingest Pipelines #154621

wants to merge 19 commits into from

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Apr 7, 2023

Add an option to filter out managed pipelines in Stack Management > Ingest Pipelines.

Resolves #153209

Before
https://www.loom.com/share/1d5731f07a724d96b4033976b5e81799

After
https://www.loom.com/share/3373fb8c5c1d42a7bc2ca2c547a05122

This code was written and reviewed by GitStart Community. Growing future engineers, one PR at a time.

@gitstart @KlingerMatheus
Add an option to filter out managed pipelines in Stack Management > I…
ab85127 
…ngest Pipelines

Co-authored-by: KlingerMatheus <[email protected]>
Co-authored-by: gitstart_bot <[email protected]>
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@gitstart gitstart changed the title ELS-80 - Add an option to filter out managed pipelines in Stack Management > Ingest Pipelines Add an option to filter out managed pipelines in Stack Management > Ingest Pipelines Apr 7, 2023
@gitstart gitstart marked this pull request as ready for review April 7, 2023 08:54
@gitstart gitstart requested a review from a team as a code owner April 7, 2023 08:54
@sabarasaba sabarasaba added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:Ingest Node Pipelines Ingest node pipelines management v8.8.0 labels Apr 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@sabarasaba sabarasaba self-requested a review April 12, 2023 12:40
@sabarasaba
Copy link
Member

@elasticmachine merge upstream

sabarasaba
sabarasaba reviewed Apr 12, 2023
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KlingerMatheus, thanks a lot for your contribution! I've tested your solution locally and works really well. I do have though a few questions and things that I think we can do improve in the implementation, let me know what you think!

x-pack/plugins/ingest_pipelines/kibana.jsonc Outdated Show resolved Hide resolved
x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/main.tsx Outdated Show resolved Hide resolved
x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/main.tsx Outdated Show resolved Hide resolved
x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/main.tsx Outdated Show resolved Hide resolved
x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/main.tsx Show resolved Hide resolved
@gitstart gitstart requested a review from sabarasaba May 5, 2023 14:28
@alisonelizabeth alisonelizabeth requested a review from a team June 30, 2023 16:33
@alisonelizabeth
Copy link
Contributor

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor

buildkite test this

@alisonelizabeth
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@alisonelizabeth
Copy link
Contributor

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor

buildkite test this

alisonelizabeth
alisonelizabeth reviewed Jul 6, 2023
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋 Thanks for addressing our feedback. I've left a few additional comments. Can you also please take screenshots of the changes and include them in the PR description? The Loom links are no longer active. Thank you!

x-pack/plugins/index_management/public/index.ts Outdated Show resolved Hide resolved
...ck/plugins/ingest_pipelines/__jest__/client_integration/ingest_pipelines_filter_list.test.ts Outdated Show resolved Hide resolved
src/plugins/es_ui_shared/public/components/filter_list_button/filter_list_button.tsx Outdated Show resolved Hide resolved
src/plugins/es_ui_shared/public/components/filter_list_button/filter_list_button.tsx Outdated Show resolved Hide resolved
@alisonelizabeth alisonelizabeth self-requested a review July 24, 2023 15:07
@alisonelizabeth
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@alisonelizabeth
Copy link
Contributor

@gitstart can you resolve the merge conflict and then I will take another look? Thanks!

@gitstart @KlingerMatheus
fix: resolved conflicts
98b123b 
Co-authored-by: Klinger Matheus <[email protected]>
Co-authored-by: gitstart_bot <[email protected]>
@alisonelizabeth
Copy link
Contributor

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor

buildkite test this

@alisonelizabeth
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

alisonelizabeth
alisonelizabeth reviewed Aug 3, 2023
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gitstart! This is getting really close. Thanks for all your work on this. I left a few other comments that I'd like to see addressed before merging. Let me know if you have questions.

x-pack/plugins/index_management/public/index.ts Outdated Show resolved Hide resolved
...k/plugins/ingest_pipelines/__jest__/client_integration/ingest_pipelines_filter_list.test.tsx Outdated Show resolved Hide resolved
x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/main.tsx Outdated Show resolved Hide resolved
x-pack/plugins/translations/translations/fr-FR.json Outdated Show resolved Hide resolved
gitstart and others added 2 commits August 8, 2023 15:10
@gitstart @KlingerMatheus
test & refactor: refactored to better legibility and code maintain, a…
93fc685 
…nd updated tests addressing feedback

Co-authored-by: Klinger Matheus <[email protected]>
Co-authored-by: gitstart_bot <[email protected]>
@gitstart @KlingerMatheus
chore: removed unused dependencies since last main update
b480785 
Co-authored-by: Klinger Matheus <[email protected]>
Co-authored-by: gitstart_bot <[email protected]>
@alisonelizabeth
Copy link
Contributor

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor

buildkite test this

@alisonelizabeth
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 25, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #56 / Options list control "before all" hook: setup in "Options list control"

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
indexManagement 177 179 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 523.6KB 522.7KB -966.0B
ingestPipelines 360.8KB 362.2KB +1.4KB
total +422.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
indexManagement 32.6KB 33.8KB +1.1KB
Unknown metric groups

API count

id before after diff
indexManagement 182 184 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yuliacech
Copy link
Contributor

Closing this PR since support for managed pipelines was added in #174814

@yuliacech yuliacech closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabarasaba sabarasaba Awaiting requested review from sabarasaba

@alisonelizabeth alisonelizabeth Awaiting requested review from alisonelizabeth

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting 💝community Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an option to filter out managed pipelines in Stack Management > Ingest Pipelines
7 participants
@gitstart @kibanamachine @elasticmachine @sabarasaba @alisonelizabeth @kibana-ci @yuliacech