Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EuiBottomBar in serverless #166840

Merged
merged 12 commits into from
Oct 4, 2023
Merged

Fix EuiBottomBar in serverless #166840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3e4229d
Fix EuiBottomBar in serverless
nchaulet Sep 20, 2023
0c44709
Fix linting
nchaulet Sep 20, 2023
9800608
Merge branch 'main' into fix-bottom-bar-serverless
kibanamachine Sep 26, 2023
11a4e7e
Add tests
nchaulet Sep 28, 2023
35b94e2
Merge branch 'main' of github.com:elastic/kibana into fix-bottom-bar-…
nchaulet Sep 28, 2023
249ac9b
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Sep 28, 2023
39b34fa
Merge branch 'main' of github.com:elastic/kibana into fix-bottom-bar-…
nchaulet Sep 29, 2023
c3696e8
Merge branch 'fix-bottom-bar-serverless' of github.com:nchaulet/kiban…
nchaulet Sep 29, 2023
316a3c0
Merge branch 'main' of github.com:elastic/kibana into fix-bottom-bar-…
nchaulet Sep 29, 2023
11a0e2b
Merge branch 'main' into fix-bottom-bar-serverless
jlind23 Oct 2, 2023
03442bb
Merge branch 'main' of github.com:elastic/kibana into fix-bottom-bar-…
nchaulet Oct 3, 2023
be9936a
Update using eui variable
nchaulet Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/chrome/core-chrome-browser-internal/src/ui/project/navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export const ProjectNavigation: React.FC = ({ children }) => {

return (
<EuiCollapsibleNavBeta
data-test-subj="projectLayoutSideNav"
initialIsCollapsed={isCollapsed}
onCollapseToggle={onCollapseToggle}
css={isCollapsed ? { display: 'none;' } : {}}
Expand Down
5 changes: 5 additions & 0 deletions src/core/public/styles/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@
margin-left: 320px; // Hard-coded for now -- @cchaos
}

// Add support for serverless nabbar
.euiBody--hasFlyout .euiBottomBar {
margin-left: var(--euiCollapsibleNavOffset, 0);
}

// Temporary fix for EuiPageHeader with a bottom border but no tabs or padding
// Will fix in EUI -- @cchaos
.euiPageHeader--bottomBorder:not(.euiPageHeader--tabsAtBottom):not([class*='euiPageHeader--padding']) {
Expand Down