-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.16] Backport rowHeightOption: auto EuiDataGrid fix #211601
[8.16] Backport rowHeightOption: auto EuiDataGrid fix #211601
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might have another issue with the auto row height, blocking this until we talk through it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing it in following browser. Looks good from my side but I will wait to see what @kqualters-elastic has encountered
- Firefox
- Chrome
- Edge ( Chromium Based )
- Brave ( Chromium Based )
- Safari
@kqualters-elastic I will update the PR with the suggestion from @jbudz just in case we proceed with the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I know what Kevin might have encountered. But let's wait for more details. As I mentioned in 8.17
backport, I am seeing the same error in this backport as well.
The error surfaces when the height of the complete table and row are both auto
.
In security Solution, whenever the number of items in Alert table is below 20, we set the table height as auto
which results in this wierd error.
Screen.Recording.2025-02-20.at.11.43.14.mov
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
|
Closing the backport PRs due to the above-mentioned issues. Going back to the drawing board with this issue. |
Summary
Fix for elastic/eui#8245
Backporting af189da to
8.16
Kibana version. It was introduced on elastic/eui#8251.The npm backport release: https://www.npmjs.com/package/@elastic/eui/v/97.0.0-backport.3
Checklist
The issue being backported, elastic/eui#8245, is intermittent. You cannot consistently reproduce it on OSX, apparently it's reproducible on Windows. I'd appreciate a manual test from the reviewers 🙏🏻
The steps to reproduce in
8.16
are:The data grid's height changes to 0. It's reproducible on first load.