Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 8.18 backport option to mergify #6507

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Conversation

jmikell821
Copy link
Contributor

Adds 8.18 backport option to mergify.

Adds `8.18` backport option to mergify
@jmikell821 jmikell821 requested a review from lcawl February 5, 2025 22:18
@jmikell821 jmikell821 self-assigned this Feb 5, 2025
@jmikell821 jmikell821 requested a review from a team as a code owner February 5, 2025 22:18
Copy link

github-actions bot commented Feb 5, 2025

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

- name: backport patches to 8.18 branch
conditions:
- merged
- base=main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This, I'm not 100% sure about since we'll no longer have a main branch to create PRs from. @lcawl should this be 8.x instead? If so, do we need to update all other instances in this file that have the base branch set to main?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm, this is probably not an issue!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember a slack discussion that said this base clause was removed from the file in the main branch since mergify was only looking at that branch... which I found to be a very confusing discussion.

But i guess worst case we keep our eyes open for the first PR that starts in 8.x and see if it's successfully backported. If not, we might need to remove or change this base clause.

@jmikell821 jmikell821 merged commit e51e491 into 8.x Feb 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants