Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use active deployment templates for acc tests #876

Merged
merged 9 commits into from
Nov 20, 2024

Conversation

gersonsosa
Copy link
Contributor

Description

Update acceptance tests with active deployment templates
Update instance configurations according to updated templates
Remove deprecated templates tests

Related Issues

Rel: https://elasticco.atlassian.net/browse/CP-9159

Motivation and Context

We need to fix the acceptance tests since we now block deprecated deployment templates in the cloud.

How Has This Been Tested?

:loading:

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Update instance configurations according to updated templates
Remove outdated templates tests
@gersonsosa gersonsosa self-assigned this Nov 13, 2024
@gersonsosa gersonsosa requested a review from a team as a code owner November 13, 2024 21:01
@dimuon
Copy link
Contributor

dimuon commented Nov 14, 2024

@gersonsosa , it seems there are still some DT and IC related failures in acc tests.

@gersonsosa
Copy link
Contributor Author

@dimuon yes, I'm going to update it sorry for the noise 🙂

@gersonsosa gersonsosa marked this pull request as draft November 14, 2024 17:57
@gersonsosa
Copy link
Contributor Author

@dimuon I discussed this with @andrew-moldovan and we think we can merge this changes now and create a separate issue I will pick immediately to fix the bug with the apm component since the bug was already present in the provider, I created this issue https://elasticco.atlassian.net/browse/CP-9334

@gersonsosa gersonsosa marked this pull request as ready for review November 19, 2024 10:27
@gersonsosa
Copy link
Contributor Author

finally is green, I'll enable some of the tests I skipped here after https://elasticco.atlassian.net/browse/CP-9334 is fixed

@gersonsosa gersonsosa merged commit 454e955 into elastic:master Nov 20, 2024
3 checks passed
@gersonsosa gersonsosa deleted the fix-acceptance-tests branch November 20, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants