ksniff graceful shutdown on Ctrl+C + Wireshark doesn't close on exit

[aviramha]

Thanks for the awesome plugin Eldad!
One annoying UX I had is if I close ksniff because I had enough traffic it also closes Wireshark.
I changed the flow so that Wireshark stays open and needed to add handling of Ctrl+C so it'll be a valid exit scenario.
This seems to fix a bug (#53 ) on capturing to a file, whereas I couldn't find a way to exit in a nice manner.

It's my first Go coding so feel free to fire away.

[aviramha]

@eldadru Bump

[eldadru]

Hi @aviramha - sorry for the delay, had a rough time..

I'll review your code today, thank you so much for this contribution!

[eldadru]

See my comments

[aviramha]

Done! Check it out :)

[eldadru]

Thanks, did you push the new code? I don't see new commits

[eldadru]

It seems the windows build is broken

pkg/cmd/sniff.go:356:4: unknown field 'Setpgid' in struct literal of type syscall.SysProcAttr pkg/cmd/sniff.go:357:4: unknown field 'Pgid' in struct literal of type syscall.SysProcAttr Makefile:26: recipe for target 'windows' failed make: *** [windows] Error 2 The command "make all" exited with 2.

[aviramha]

Should I create a _linux and _windows file for the specific procedure? (not sure what's the go approach here)

[eldadru]

Hi @aviramha, sorry again for the late response...

In this case, I believe the cleaner approach is to extract the process execution code to its own struct and hide the "specific os code" there, the struct will expose a single call to execute the Wireshark command.

WDYT?

[aviramha]

Sounds good, from what I understand specific OS code can be seperated only by files, so I assume that we'll have windows file and unix file?

[Slach]

@aviramha any news about this PR?

[aviramha]

@aviramha any news about this PR?

I don't think I'll get to it soon. Feel free to continue where I left it :)

[bostrt]

Hey @aviramha, your hard work so far is very much appreciated! I just wanted to check-in and see if you think you'd be able to continue work on this PR?

[aviramha]

I don't think so

[pnovotnak]

I can take this over, I spend a few mins each day killing off tcpdump binaries (let alone the ones I forget) so I may as well just spend an hour up front.

In this case, I believe the cleaner approach is to extract the process execution code to its own struct and hide the "specific os code" there, the struct will expose a single call to execute the Wireshark command.

@bostrt you're saying the contents of the (o *Ksniff) Run() function ought to be hidden in a struct, yea?