Build with Vite #311
Merged
Build with Vite #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vite is a significantly faster builder than Webpack which the JS ecosystem seems to be adopting widely. We're already using for Compound Web, and Storybook makes it pretty simple to swap it out for Webpack, so that's what I've done here.
pixlwave
approved these changes
Feb 5, 2024
|
As per discussion with @dbkr the Cloudflare failure is because vite requires a newer version of Node than we have configured. https://gitlab.matrix.org/infrastructure/cloudflare/-/merge_requests/232 to change this in preview, will also need changing in production once confirmed it works and is safe to do |
Deploying with
|
| Latest commit: |
f2ff3e9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6d50c199.compound-5m4.pages.dev |
| Branch Preview URL: | https://vite.compound-5m4.pages.dev |
|
@benbz Can we go ahead and change the Node version in production? The preview is working, so I'm ready to merge this once production is updated. |
|
https://gitlab.matrix.org/infrastructure/cloudflare/-/merge_requests/236 for production. Good for me to merge and apply? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vite is a significantly faster builder than Webpack which the JS ecosystem seems to be adopting widely. We're already using it successfully for Compound Web, and Storybook makes it pretty simple to swap it out for Webpack, so that's what I've done here.