Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert usage of stable fields in live location sharing and polls #7752

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Revert usage of stable fields in live location sharing and polls #7752

merged 2 commits into from
Dec 9, 2022

Conversation

mnaturel
Copy link
Contributor

@mnaturel mnaturel commented Dec 9, 2022 •
edited
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Change usage of stable fields to the unstable ones in live location share and polls events.

Motivation and context

Closes #7751

Screenshots / GIFs

Tests

  • Check live location share is working correctly in a room
  • Check creation of polls is working correctly in a room

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel marked this pull request as ready for review December 9, 2022 08:38
@mnaturel mnaturel requested review from a team and jonnyandrew and removed request for a team December 9, 2022 08:38
@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

28.6% 28.6% Coverage
0.0% 0.0% Duplication

@mnaturel mnaturel merged commit dba8aae into develop Dec 9, 2022
@mnaturel mnaturel deleted the fix/mna/wrong-usage-of-stable-fields branch December 9, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnyandrew jonnyandrew jonnyandrew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert usage of stable fields in live location sharing and polls
2 participants
@mnaturel @jonnyandrew