[Spaces] M10.5 Show suggested in room lists #4501 #4658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Request space suggested rooms in `RecentsDataSource`
…om_lists # Conflicts: # Riot/Modules/Common/Recents/DataSources/RecentsDataSource.m
- Show suggested rooms section in home screen (no actions) - Show suggested rooms section in rooms screen (no actions)
- Preview suggested rooms
…om_lists # Conflicts: # Riot/Modules/Common/Recents/DataSources/RecentsDataSource.m
gileluard
changed the title
niquewoodhouse
approved these changes
Aug 12, 2021
|
|
||
| import Foundation | ||
|
|
||
| extension MXSpaceChildInfo { |
There was a problem hiding this comment.
We should use RoomAvatarView or factorize this code for existing place where RoomAvatarView is not used. It seems copy paste several time.
There was a problem hiding this comment.
@SBiOSoftWhare I don't understand your comment. setRoomAvatarImage is a method called twice alongside the method setRoomAvatarImage of the MXRoomSummary.
There was a problem hiding this comment.
In fact if we can't use AvatarImageView subclass we can make an intermediate extension on MKImageView like this to avoid code duplication:
extension MXKImageView {
func vc_setRoomAvatarImage(with url: String?, displayName: String, mediaManager: MXMediaManager) {
}
}
| @@ -1275,8 +1345,17 @@ + (RecentsDataSourceState *)computeStateWithCells:(NSArray<id<MXKRecentCellDataS | |||
| } | |||
| else if (recentsDataSourceMode == RecentsDataSourceModeRooms) | |||
| { | |||
| if (recentCellDataStoring.spaceChildInfo) | |||
There was a problem hiding this comment.
Can we add a small comment
- Update after code review
- Update after code review
SBiOSoftWhare
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4501
Note that room preview may change.
@vector-im/design testable build here: https://i.diawi.com/WeA7ZY