Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer native apps over PWA #28172

Closed
wants to merge 1 commit into from
Closed

Conversation

jake-anto
Copy link

@jake-anto jake-anto commented Oct 9, 2024

This PR enables the native app install prompt for the PWA by setting the prefer_related_applications property to true in the manifest. This property tells the browser to suggest the installation of the native app (if supported) listed in related_applications, instead of the PWA.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@jake-anto jake-anto requested a review from a team as a code owner October 9, 2024 15:37
@CLAassistant
Copy link

CLAassistant commented Oct 9, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Oct 9, 2024
@dbkr dbkr requested a review from a team October 9, 2024 16:46
@langleyd
Copy link
Member

@jake-anto Can you add screenshots of the experience to the PR(for different browsers if the experience is difference) to make it easier for the Product team assess this contribution? Thanks

@langleyd
Copy link
Member

langleyd commented Dec 5, 2024

@jake-anto Please re-open with screenshots if you would like the product team to consider this, thanks.

@langleyd langleyd closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants