Remove space-specific right panel store handling #28538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer needed as the right panel always corresponds to the currently viewed room/space only. Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
…to t3chguy/fix/20721
MidhunSureshR
approved these changes
Nov 28, 2024
Signed-off-by: Michael Telatynski <[email protected]>
t3chguy
commented
Dec 2, 2024
Comment on lines
111
to
118
| // redraw the badge on the membership list | ||
| if (this.state.phase === RightPanelPhases.RoomMemberList) { | ||
| if (this.state.phase === RightPanelPhases.MemberList) { | ||
| this.delayedUpdate(); | ||
| } else if ( | ||
| this.state.phase === RightPanelPhases.RoomMemberInfo && | ||
| this.state.phase === RightPanelPhases.MemberInfo && | ||
| member.userId === this.state.cardState?.member?.userId | ||
| ) { | ||
| // refresh the member info (e.g. new power level) |
There was a problem hiding this comment.
This part isn't really testable, relies on forceUpdate and is all sorts of hellish
t3chguy
commented
Dec 2, 2024
Comment on lines
+1823
to
1825
| if (RightPanelStore.instance.previousCard.phase === RightPanelPhases.MemberList) { | ||
| PosthogTrackers.trackInteraction("WebRightPanelRoomUserInfoBackButton", ev); | ||
| } |
There was a problem hiding this comment.
This isn't sanely testable
Signed-off-by: Michael Telatynski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is no longer needed as the right panel always corresponds to the currently viewed room/space only.
Fixes #20721