Switch to using @fontsource for Inter & Inconsolata #28540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
…to t3chguy/fix/25969 # Conflicts: # res/themes/light/css/_fonts.pcss # yarn.lock
Signed-off-by: Michael Telatynski <[email protected]>
…to t3chguy/fix/25969
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
…to t3chguy/fix/25969 Signed-off-by: Michael Telatynski <[email protected]>
dbkr
approved these changes
Dec 4, 2024
| when variation-16 is applied to request the emoji variant. From eyeballing | ||
| the emoji picker, these are: 20e3, 23cf, 24c2, 25a0-25c1, 2665, 2764, 2b06, 2b1c. | ||
| Therefore we define a unicode-range to load which excludes the glyphs | ||
| (to avoid having to maintain a fork of Inter). */ |
There was a problem hiding this comment.
Indeed, not possible but also not necessary. fontsource adds the correct unicode ranges for each font-face definition
gaelledel
approved these changes
Dec 4, 2024
gaelledel
approved these changes
Dec 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25969
Updates from Inter 3.18 to Inter 4.1 so has some visual changes
Switches Playwright screenshot tests to new headless mode to make the font rendering match reality, also upgrades to Noble to ensure screenshots match between CI & Docker dev.
No point splitting up the PR as the headless mode/noble PR would have to update all the screenshots, as would this fontsource PR, so we'd have to update it twice.