Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update new ShareDialog #28595

Closed
wants to merge 1 commit into from
Closed

Update new ShareDialog #28595

wants to merge 1 commit into from

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Nov 29, 2024 •
edited
Loading

This still makes the old share dialog the default export but alsoe exposes the new dialog style.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@toger5 toger5 force-pushed the toger5/new-share-style branch from ccad85a to 319030b Compare November 29, 2024 12:06
@florianduros
Copy link
Member

florianduros commented Nov 29, 2024 •
edited
Loading

Closing in of favour of #28598

@t3chguy
Copy link
Member

t3chguy commented Dec 2, 2024

@florianduros you closed this PR in favour of itself?

@florianduros
Copy link
Member

@t3chguy updated, wrong c/c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toger5 @florianduros @t3chguy