Factor out crypto setup process into a store #28675
Conversation
To make components pure and avoid react 18 dev mode problems due to components making requests when mounted.
| this.emit("update"); | ||
| this.onFinished?.(true); | ||
| } catch (e) { | ||
| if (this.isTokenLogin) { |
There was a problem hiding this comment.
Why the status is not "error" if there is a login token?
There was a problem hiding this comment.
I wish I knew: this comment is all there was so I moved it over. Possibly because if the user's using token login and the grace period didn't work, nothing else will so it's better to just carry on and bug the user later to set up crypto rather than worry them? Maybe the real answer is that we should drop support for HSes without the key upload grace period.
| this.stores = stores; | ||
| this.onFinished = onFinished; | ||
|
|
||
| this.doSetup().catch(() => logger.error("Initial crypto setup failed")); |
There was a problem hiding this comment.
Why we are not waiting for doSetup to finish?
There was a problem hiding this comment.
It just seemed unnecessary and would conflate the interface I think. Added a comment.
There was a problem hiding this comment.
I am not really familiar with this store pattern for react :/
Don't know what a pure component should be, but FWIW looks ok.
I think that several things moved/refactored are deprecated and at some point should be droped (don't need to save password there is the grace period, and reauth not need for initial setup of cross signing keys https://github.com/matrix-org/matrix-spec-proposals/blob/hughns/device-signing-upload-uia/proposals/3967-device-signing-upload-uia.md
| this.emit("update"); | ||
|
|
||
| try { | ||
| await createCrossSigning(this.client, this.isTokenLogin, this.stores.accountPasswordStore.getPassword()); |
There was a problem hiding this comment.
The password thing look like something that should be removed. Because MSC3967 has been merged and re-auth will not be required to setup cross signing for the first time.
And also anyhow the grace period is managed by the server.
There was a problem hiding this comment.
Yeah, I was hoping we could remove this soon. I wouldn't do that in a refactor though.
To make components pure and avoid react 18 dev mode problems due to components making requests when mounted.
Checklist
public/exportedsymbols have accurate TSDoc documentation.