Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peter-evans/create-pull-request digest to 67ccf78 #28897

Merged
merged 1 commit into from
Jan 7, 2025
+2 −2
Merged

Update peter-evans/create-pull-request digest to 67ccf78 #28897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/playwright-image-updates.yaml
View file
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@ jobs:

- name: Create Pull Request
id: cpr
uses: peter-evans/create-pull-request@5e914681df9dc83aa4e4905692ca88beb2f9e91f # v7
uses: peter-evans/create-pull-request@67ccf781d68cd99b580ae25a5c18a1cc84ffff1f # v7
with:
token: ${{ secrets.ELEMENT_BOT_TOKEN }}
branch: actions/playwright-image-updates
2 changes: 1 addition & 1 deletion .github/workflows/update-jitsi.yml
View file
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@ jobs:
run: "yarn update:jitsi"

- name: Create Pull Request
uses: peter-evans/create-pull-request@5e914681df9dc83aa4e4905692ca88beb2f9e91f # v7
uses: peter-evans/create-pull-request@67ccf781d68cd99b580ae25a5c18a1cc84ffff1f # v7
with:
token: ${{ secrets.ELEMENT_BOT_TOKEN }}
branch: actions/jitsi-update

Unchanged files with check annotations Beta

View file
playwright/e2e/room_options/marked_unread.spec.ts
await roomTile.getByRole("button", { name: "Room options" }).click();
await page.getByRole("menuitem", { name: "Mark as unread" }).click();
expect(page.getByLabel(TEST_ROOM_NAME + " Unread messages.")).toBeVisible();

Check failure on line 51 in playwright/e2e/room_options/marked_unread.spec.ts

GitHub Actions / Run Tests [Chrome] 4/6

[Chrome] › room_options/marked_unread.spec.ts:22:9 › Mark as Unread › should mark a room as unread 

  1) [Chrome] › room_options/marked_unread.spec.ts:22:9 › Mark as Unread › should mark a room as unread 
    Error: expect(locator).toBeVisible()

    Locator: getByLabel('The mark unread test room Unread messages.')
    Expected: visible
    Received: <element(s) not found>
    Call log:
      - expect.toBeVisible with timeout 5000ms
      - waiting for getByLabel('The mark unread test room Unread messages.')


      49 |         await page.getByRole("menuitem", { name: "Mark as unread" }).click();
      50 |
    > 51 |         expect(page.getByLabel(TEST_ROOM_NAME + " Unread messages.")).toBeVisible();
         |                                                                       ^
      52 |     });
      53 | });
      54 |
        at /home/runner/work/element-web/element-web/playwright/e2e/room_options/marked_unread.spec.ts:51:71
});
});
View file
playwright/e2e/audio-player/audio-player.spec.ts
/*

Check failure on line 1 in playwright/e2e/audio-player/audio-player.spec.ts

GitHub Actions / Run Tests [Chrome] 1/6

[Chrome] › audio-player/audio-player.spec.ts:243:9 › Audio player › should support creating a reply chain with multiple audio files @no-firefox @no-webkit @screenshot 

  1) [Chrome] › audio-player/audio-player.spec.ts:243:9 › Audio player › should support creating a reply chain with multiple audio files @no-firefox @no-webkit @screenshot 
    Test timeout of 30000ms exceeded.
Copyright 2024 New Vector Ltd.
Copyright 2023 Suguru Hirahara
Copyright 2023 The Matrix.org Foundation C.I.C.
// Find and click "Reply" button
const clickButtonReply = async () => {
await tile.hover();
await tile.getByRole("button", { name: "Reply", exact: true }).click();

Check failure on line 257 in playwright/e2e/audio-player/audio-player.spec.ts

GitHub Actions / Run Tests [Chrome] 1/6

[Chrome] › audio-player/audio-player.spec.ts:243:9 › Audio player › should support creating a reply chain with multiple audio files @no-firefox @no-webkit @screenshot 

  1) [Chrome] › audio-player/audio-player.spec.ts:243:9 › Audio player › should support creating a reply chain with multiple audio files @no-firefox @no-webkit @screenshot 
    Error: locator.click: Test timeout of 30000ms exceeded.
    Call log:
      - waiting for locator('.mx_EventTile_last').getByRole('button', { name: 'Reply', exact: true })


      255 |             const clickButtonReply = async () => {
      256 |                 await tile.hover();
    > 257 |                 await tile.getByRole("button", { name: "Reply", exact: true }).click();
          |                                                                                ^
      258 |             };
      259 |
      260 |             await uploadFile(page, "playwright/sample-files/upload-first.ogg");
        at clickButtonReply (/home/runner/work/element-web/element-web/playwright/e2e/audio-player/audio-player.spec.ts:257:80)
        at /home/runner/work/element-web/element-web/playwright/e2e/audio-player/audio-player.spec.ts:273:13
};
await uploadFile(page, "playwright/sample-files/upload-first.ogg");
View file
playwright/e2e/settings/general-room-settings-tab.spec.ts
await settings.locator("#roomAliases").getByText("Add", { exact: true }).click();
// 2. wait for the new setting to apply ...
await expect(settings.locator("#canonicalAlias")).toHaveValue(`#${longString}:localhost`);

Check failure on line 47 in playwright/e2e/settings/general-room-settings-tab.spec.ts

GitHub Actions / Run Tests [Chrome] 5/6

[Chrome] › settings/general-room-settings-tab.spec.ts:39:9 › General room settings tab › long address should not cause dialog to overflow @no-webkit 

  1) [Chrome] › settings/general-room-settings-tab.spec.ts:39:9 › General room settings tab › long address should not cause dialog to overflow @no-webkit 
    Error: Timed out 5000ms waiting for expect(locator).toHaveValue(expected)

    Locator: locator('.mx_Dialog').filter({ has: locator('.mx_RoomSettingsDialog') }).locator('#canonicalAlias')
    Expected string: "#abcasdhjasjhdaj1jh1asdhasjdhajsdhjavhjksdabcasdhjasjhdaj1jh1asdhasjdhajsdhjavhjksdabcasdhjasjhdaj1jh1asdhasjdhajsdhjavhjksdabcasdhjasjhdaj1jh1asdhasjdhajsdhjavhjksd:localhost"
    Received string: ""
    Call log:
      - expect.toHaveValue with timeout 5000ms
      - waiting for locator('.mx_Dialog').filter({ has: locator('.mx_RoomSettingsDialog') }).locator('#canonicalAlias')
        9 × locator resolved to <select type="text" id="canonicalAlias" label="Main address" placeholder="Main address">…</select>
          - unexpected value ""


      45 |
      46 |         // 2. wait for the new setting to apply ...
    > 47 |         await expect(settings.locator("#canonicalAlias")).toHaveValue(`#${longString}:localhost`);
         |                                                           ^
      48 |
      49 |         // 3. Check if the dialog overflows
      50 |         const dialogBoundingBox = await page.locator(".mx_Dialog").boundingBox();
        at /home/runner/work/element-web/element-web/playwright/e2e/settings/general-room-settings-tab.spec.ts:47:59
// 3. Check if the dialog overflows
const dialogBoundingBox = await page.locator(".mx_Dialog").boundingBox();
View file
playwright/element-web-test.ts
})) as ElementHandle<Element>;
const screenshotName = sanitizeFilePathBeforeExtension(name);
await baseExpect(receiver).toHaveScreenshot(screenshotName, options);

Check failure on line 367 in playwright/element-web-test.ts

GitHub Actions / Run Tests [Chrome] 5/6

[Chrome] › share-dialog/share-dialog.spec.ts:19:9 › Share dialog › should share a room @screenshot 

  2) [Chrome] › share-dialog/share-dialog.spec.ts:19:9 › Share dialog › should share a room @screenshot 
    Error: expect.toHaveScreenshot(share-dialog-room.png): Test ended.
    Call log:
      - expect.toHaveScreenshot(share-dialog-room.png) with timeout 5000ms
        - verifying given screenshot expectation
      - waiting for getByRole('dialog', { name: 'Share room' })


       at ../element-web-test.ts:367

      365 |
      366 |         const screenshotName = sanitizeFilePathBeforeExtension(name);
    > 367 |         await baseExpect(receiver).toHaveScreenshot(screenshotName, options);
          |         ^
      368 |
      369 |         await style.evaluate((tag) => tag.remove());
      370 |
        at Object.toMatchScreenshot (/home/runner/work/element-web/element-web/playwright/element-web-test.ts:367:9)

Check failure on line 367 in playwright/element-web-test.ts

GitHub Actions / Run Tests [Chrome] 5/6

[Chrome] › share-dialog/share-dialog.spec.ts:32:9 › Share dialog › should share a room member @screenshot 

  3) [Chrome] › share-dialog/share-dialog.spec.ts:32:9 › Share dialog › should share a room member @screenshot 
    Error: expect.toHaveScreenshot(share-dialog-user.png): Test ended.
    Call log:
      - expect.toHaveScreenshot(share-dialog-user.png) with timeout 5000ms
        - verifying given screenshot expectation
      - waiting for getByRole('dialog', { name: 'Share User' })


       at ../element-web-test.ts:367

      365 |
      366 |         const screenshotName = sanitizeFilePathBeforeExtension(name);
    > 367 |         await baseExpect(receiver).toHaveScreenshot(screenshotName, options);
          |         ^
      368 |
      369 |         await style.evaluate((tag) => tag.remove());
      370 |
        at Object.toMatchScreenshot (/home/runner/work/element-web/element-web/playwright/element-web-test.ts:367:9)

Check failure on line 367 in playwright/element-web-test.ts

GitHub Actions / Run Tests [Chrome] 5/6

[Chrome] › share-dialog/share-dialog.spec.ts:49:9 › Share dialog › should share an event @screenshot 

  4) [Chrome] › share-dialog/share-dialog.spec.ts:49:9 › Share dialog › should share an event @screenshot 
    Error: expect.toHaveScreenshot(share-dialog-event.png): Test ended.
    Call log:
      - expect.toHaveScreenshot(share-dialog-event.png) with timeout 5000ms
        - verifying given screenshot expectation
      - waiting for getByRole('dialog', { name: 'Share Room Message' })
        - locator resolved to <div role="dialog" class="mx_ShareDialog" data-focus-lock-disabled="false" aria-describedby="mx_Dialog_content" aria-labelledby="mx_BaseDialog_title">…</div>
      - taking element screenshot
        - disabled all CSS animations
      - waiting for fonts to load...
      - fonts loaded
      - attempting scroll into view action
        - waiting for element to be stable


       at ../element-web-test.ts:367

      365 |
      366 |         const screenshotName = sanitizeFilePathBeforeExtension(name);
    > 367 |         await baseExpect(receiver).toHaveScreenshot(screenshotName, options);
          |         ^
      368 |
      369 |         await style.evaluate((tag) => tag.remove());
      370 |
        at Object.toMatchScreenshot (/home/runner/work/element-web/element-web/playwright/element-web-test.ts:367:9)
await style.evaluate((tag) => tag.remove());
View file
playwright/e2e/sliding-sync/sliding-sync.spec.ts
if (body.txn_id === undefined) {
return;
}
expect(body.unsubscribe_rooms).toEqual([unsubRoomId]);

Check failure on line 372 in playwright/e2e/sliding-sync/sliding-sync.spec.ts

GitHub Actions / Run Tests [Chrome] 5/6

[Chrome] › sliding-sync/sliding-sync.spec.ts:356:5 › Sliding Sync › should send unsubscribe_rooms for every room switch 

  5) [Chrome] › sliding-sync/sliding-sync.spec.ts:356:5 › Sliding Sync › should send unsubscribe_rooms for every room switch 
    Error: expect(received).toEqual(expected) // deep equality

    Expected: ["!PusjIIAbOtaLkxErVN:localhost"]
    Received: undefined

      370 |                 return;
      371 |             }
    > 372 |             expect(body.unsubscribe_rooms).toEqual([unsubRoomId]);
          |                                            ^
      373 |             expect(body.room_subscriptions).not.toHaveProperty(unsubRoomId);
      374 |             expect(body.room_subscriptions).toHaveProperty(subRoomId);
      375 |         };
        at assertUnsubExists (/home/runner/work/element-web/element-web/playwright/e2e/sliding-sync/sliding-sync.spec.ts:372:44)
        at /home/runner/work/element-web/element-web/playwright/e2e/sliding-sync/sliding-sync.spec.ts:394:9
expect(body.room_subscriptions).not.toHaveProperty(unsubRoomId);
expect(body.room_subscriptions).toHaveProperty(subRoomId);
};