Switch to secure random strings #29013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the js-sdk methods are changing and there's no reason for these not to use the secure versions. The dedicated upper/lower functions were *only* used in this one case, so this should do the exact same thing with the one exported function. Requires matrix-org/matrix-js-sdk#4621 (merge both together)
which I somehow entirely missed the first time.
t3chguy
approved these changes
Jan 16, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
t3chguy
added
the
backport staging
RiotRobot
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Switch to secure random strings Because the js-sdk methods are changing and there's no reason for these not to use the secure versions. The dedicated upper/lower functions were *only* used in this one case, so this should do the exact same thing with the one exported function. Requires matrix-org/matrix-js-sdk#4621 (merge both together) * Change remaining instances of randomString which I somehow entirely missed the first time. * Fix import order (cherry picked from commit 56eafc9)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Switch to secure random strings Because the js-sdk methods are changing and there's no reason for these not to use the secure versions. The dedicated upper/lower functions were *only* used in this one case, so this should do the exact same thing with the one exported function. Requires matrix-org/matrix-js-sdk#4621 (merge both together) * Change remaining instances of randomString which I somehow entirely missed the first time. * Fix import order (cherry picked from commit 56eafc9) Co-authored-by: David Baker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the js-sdk methods are changing and there's no reason for these not to use the secure versions. The dedicated upper/lower functions were only used in this one case, so this should do the exact same thing with the one exported function.
Others were just using randomString, none look speed-sensitive so I don't think we really need to maintain an insecure set of functions too.
Requires matrix-org/matrix-js-sdk#4621 (merge both together)
Checklist
public/exportedsymbols have accurate TSDoc documentation.