Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Upgrade to latest compound-web package #84

Merged
merged 11 commits into from
Oct 14, 2024
Merged

Conversation

MidhunSureshR
Copy link
Member

@MidhunSureshR MidhunSureshR commented Sep 22, 2024

compound-web 6.0.0 release introduced some breaking changes related to Tooltips.

  • Brought back <TooltipProvider> component to all the root components. It was removed in Use new compound tooltip matrix-org/matrix-react-sdk#12416.
  • Adds a custom render function that wraps the component under test with <TooltipProvider>. All tests must now import from jest-matrix-react instead of @testing-library/react. An eslint rule is added to enforce the same.
  • When providing label to Tooltip, it acts as an accessible label for the enclosed element. Also when used in this manner, role=tooltip is not added. Since this was the primary way tooltips were found and asserted, a lot of tests broke. They are fixed by searching via text or by using description prop instead of `label prop.
  • Fixes wrap-ansi / commonjs dependency horror element-web#28087 by pinning wrap-ansi and wrap-ansi-cjs to a specific version. Yarn is otherwise unable to understand that these are both the same package. This would result in yarn install failing perpetually.
  • <ToggleMenuItem> no longer has an onChange, updated src/components/views/right_panel/RoomSummaryCard.tsx.
  • Playwright accessibility tests will ignore elements with id starting with floating-ui-. These are the divs outside .MatrixChat where the tooltips are rendered. The reason for fail: Ensure all page content is contained by landmarks. Since the tooltips are only shown on user interaction, this is probably fine.
  • Increased timeout for flaky tests - here and here.

@MidhunSureshR MidhunSureshR added the T-Task Tasks for the team like planning label Sep 22, 2024
@CLAassistant
Copy link

CLAassistant commented Sep 22, 2024

CLA assistant check
All committers have signed the CLA.

@MidhunSureshR
Copy link
Member Author

Needs element-hq/compound-web#248 for fixing the type error.

@MidhunSureshR MidhunSureshR force-pushed the midhun/compound-upgrade branch from 48ed462 to d3d6f2c Compare September 24, 2024 09:05
@MidhunSureshR MidhunSureshR force-pushed the midhun/compound-upgrade branch from 4978422 to 95b6b1b Compare September 24, 2024 18:16
@MidhunSureshR MidhunSureshR force-pushed the midhun/compound-upgrade branch from 6e3ef61 to 481ea9e Compare September 28, 2024 20:07
@t3chguy
Copy link
Member

t3chguy commented Oct 8, 2024

Maybe this could be broken down to 2, decoupling the jest-matrix-react stuff from the compound upgrade as having snapshots update whilst tests are also changing increases the risk

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the crypto POV. Will leave it to the web team to decide if they are happy with combining the jest-matrix-react stuff with the compound upgrade

@MidhunSureshR MidhunSureshR added this pull request to the merge queue Oct 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 8, 2024
@MidhunSureshR MidhunSureshR added this pull request to the merge queue Oct 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 8, 2024
@MidhunSureshR MidhunSureshR added this pull request to the merge queue Oct 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 8, 2024
@MidhunSureshR MidhunSureshR added this pull request to the merge queue Oct 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 8, 2024
@MidhunSureshR MidhunSureshR added this pull request to the merge queue Oct 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 9, 2024
@t3chguy t3chguy enabled auto-merge October 14, 2024 15:06
@t3chguy t3chguy added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@t3chguy t3chguy added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@t3chguy t3chguy added this pull request to the merge queue Oct 14, 2024
Merged via the queue into develop with commit 91e84f7 Oct 14, 2024
27 checks passed
@t3chguy t3chguy deleted the midhun/compound-upgrade branch October 14, 2024 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrap-ansi / commonjs dependency horror
5 participants