-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that pending to-device events are sent over federation at startup #16925
Merged
Commits on Feb 15, 2024
-
Include destinations we never sent to in catchup
When picking destination servers that we need to wake up for a retry, we need to be mindful of destinations that we have *never* successfully sent to. This can manifest either as a null `last_successful_stream_ordering`, or even no row in `destinations` at all. Hence, we need to left-join on `destinations` rather than inner-joining, and we need to treat a null `last_successful_stream_ordering` the same as 0.
Configuration menu - View commit details
-
Copy full SHA for bd010d7 - Browse repository at this point
Copy the full SHA bd010d7View commit details -
Include destinations with to-device messages in catchup
When considering which destinations need waking up for a retry, also look for those that have outstanding to-device messages.
Configuration menu - View commit details
-
Copy full SHA for 3e467d3 - Browse repository at this point
Copy the full SHA 3e467d3View commit details -
Kick off the destination wakeup job immediately at startup
We don't really want people to have to wait 60 seconds for their to-device messages.
Configuration menu - View commit details
-
Copy full SHA for ce234c2 - Browse repository at this point
Copy the full SHA ce234c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for edc8155 - Browse repository at this point
Copy the full SHA edc8155View commit details
Commits on Mar 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b7908ac - Browse repository at this point
Copy the full SHA b7908acView commit details
Commits on Mar 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6c73ba2 - Browse repository at this point
Copy the full SHA 6c73ba2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a63ffc8 - Browse repository at this point
Copy the full SHA a63ffc8View commit details
Commits on Mar 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0bf54b7 - Browse repository at this point
Copy the full SHA 0bf54b7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.