Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 'runtime error' to the default monitored statuses. #1080

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Added 'runtime error' to the default monitored statuses. #1080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35efce4
Added 'runtime error' to the default monitored statuses.
elongl Aug 15, 2023
6b3554b
Added tests.
elongl Aug 15, 2023
add191d
Fixed tests.
elongl Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion elementary/monitor/data_monitoring/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ class Status(Enum):
FAIL = "fail"
SKIPPED = "skipped"
ERROR = "error"
RUNTIME_ERROR = "runtime error"


class ResourceType(Enum):
Expand Down Expand Up @@ -52,7 +53,12 @@ class SelectorFilterSchema(BaseModel):
tag: Optional[str] = None
owner: Optional[str] = None
model: Optional[str] = None
statuses: Optional[List[Status]] = [Status.FAIL, Status.ERROR, Status.WARN]
statuses: Optional[List[Status]] = [
Status.FAIL,
Status.ERROR,
Status.RUNTIME_ERROR,
Status.WARN,
]
resource_types: Optional[List[ResourceType]] = None
node_names: Optional[List[str]] = None

Expand Down
111 changes: 102 additions & 9 deletions tests/unit/monitor/api/alerts/test_alert_filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from elementary.monitor.alerts.malformed import MalformedAlert
from elementary.monitor.alerts.model import ModelAlert
from elementary.monitor.alerts.source_freshness import SourceFreshnessAlert
from elementary.monitor.alerts.test import TestAlert
from elementary.monitor.api.alerts.alert_filters import (
_filter_alerts_by_model,
Expand Down Expand Up @@ -150,11 +151,88 @@ def initial_alerts():
),
),
]
return test_alerts, model_alerts, malformed_alerts
source_freshness_alerts = [
SourceFreshnessAlert(
id="1",
alert_class_id="elementary.model_id_1",
model_unique_id="elementary.model_id_1",
alias="modely",
path="my/path",
original_path="",
materialization="table",
message="",
full_refresh=False,
detected_at="2022-10-10 10:00:00",
alert_suppression_interval=0,
tags='["one", "two"]',
owners='["jeff", "john"]',
status="error",
snapshotted_at="2023-08-15T12:26:06.884065+00:00",
max_loaded_at="1969-12-31T00:00:00+00:00",
max_loaded_at_time_ago_in_s=1692188766.884065,
source_name="elementary_integration_tests",
identifier="any_type_column_anomalies_validation",
freshness_error_after='{"count": null, "period": null}',
freshness_warn_after='{"count": 1, "period": "minute"}',
freshness_filter="null",
error="problemz",
),
SourceFreshnessAlert(
id="2",
alert_class_id="elementary.model_id_2",
model_unique_id="elementary.model_id_2",
alias="modely",
path="my/path",
original_path="",
materialization="table",
message="",
full_refresh=False,
detected_at="2022-10-10 10:00:00",
alert_suppression_interval=0,
tags='["one", "two"]',
owners='["jeff", "john"]',
status="warn",
snapshotted_at="2023-08-15T12:26:06.884065+00:00",
max_loaded_at="1969-12-31T00:00:00+00:00",
max_loaded_at_time_ago_in_s=1692188766.884065,
source_name="elementary_integration_tests",
identifier="any_type_column_anomalies_validation",
freshness_error_after='{"count": null, "period": null}',
freshness_warn_after='{"count": 1, "period": "minute"}',
freshness_filter="null",
error="problemz",
),
SourceFreshnessAlert(
id="3",
alert_class_id="elementary.model_id_3",
model_unique_id="elementary.model_id_3",
alias="modely",
path="my/path",
original_path="",
materialization="table",
message="",
full_refresh=False,
detected_at="2022-10-10 10:00:00",
alert_suppression_interval=0,
tags='["one", "two"]',
owners='["jeff", "john"]',
status="runtime error",
snapshotted_at="2023-08-15T12:26:06.884065+00:00",
max_loaded_at="1969-12-31T00:00:00+00:00",
max_loaded_at_time_ago_in_s=1692188766.884065,
source_name="elementary_integration_tests",
identifier="any_type_column_anomalies_validation",
freshness_error_after='{"count": null, "period": null}',
freshness_warn_after='{"count": 1, "period": "minute"}',
freshness_filter="null",
error="problemz",
),
]
return test_alerts, model_alerts, malformed_alerts, source_freshness_alerts


def test_filter_alerts():
test_alerts, model_alerts, malformed_alerts = initial_alerts()
test_alerts, model_alerts, malformed_alerts, _ = initial_alerts()

# Test that empty filter returns all of the alerts except for skipped.
filter = SelectorFilterSchema()
Expand Down Expand Up @@ -184,7 +262,7 @@ def test_filter_alerts():


def test_filter_alerts_by_tag():
test_alerts, model_alerts, malformed_alerts = initial_alerts()
test_alerts, model_alerts, malformed_alerts, _ = initial_alerts()

filter = SelectorFilterSchema(tag="one")
filter_test_alerts = _filter_alerts_by_tag(test_alerts, filter)
Expand Down Expand Up @@ -222,7 +300,7 @@ def test_filter_alerts_by_tag():


def test_filter_alerts_by_owner():
test_alerts, model_alerts, malformed_alerts = initial_alerts()
test_alerts, model_alerts, malformed_alerts, _ = initial_alerts()

filter = SelectorFilterSchema(owner="jeff")
filter_test_alerts = _filter_alerts_by_owner(test_alerts, filter)
Expand Down Expand Up @@ -255,7 +333,7 @@ def test_filter_alerts_by_owner():


def test_filter_alerts_by_model():
test_alerts, model_alerts, malformed_alerts = initial_alerts()
test_alerts, model_alerts, malformed_alerts, _ = initial_alerts()

filter = SelectorFilterSchema(model="model_id_1")
filter_test_alerts = _filter_alerts_by_model(test_alerts, filter)
Expand Down Expand Up @@ -284,7 +362,7 @@ def test_filter_alerts_by_model():


def test_filter_alerts_by_node_names():
test_alerts, model_alerts, malformed_alerts = initial_alerts()
test_alerts, model_alerts, malformed_alerts, _ = initial_alerts()

filter = SelectorFilterSchema(node_names=["test_3", "model_id_1"])
filter_test_alerts = _filter_alerts_by_node_names(test_alerts, filter)
Expand Down Expand Up @@ -322,16 +400,25 @@ def test_filter_alerts_by_node_names():


def test_filter_alerts_by_statuses():
test_alerts, model_alerts, malformed_alerts = initial_alerts()
(
test_alerts,
model_alerts,
malformed_alerts,
source_freshness_alerts,
) = initial_alerts()

filter = SelectorFilterSchema(statuses=[Status.WARN])
filter_test_alerts = _filter_alerts_by_status(test_alerts, filter)
filter_model_alerts = _filter_alerts_by_status(model_alerts, filter)
filter_malformed_alerts = _filter_alerts_by_status(malformed_alerts, filter)
filter_source_freshness_alerts = _filter_alerts_by_status(
source_freshness_alerts, filter
)
assert len(filter_test_alerts) == 1
assert filter_test_alerts[0].id == "4"
assert len(filter_model_alerts) == 0
assert len(filter_malformed_alerts) == 0
assert len(filter_source_freshness_alerts) == 1

filter = SelectorFilterSchema(statuses=[Status.ERROR, Status.SKIPPED])
filter_test_alerts = _filter_alerts_by_status(test_alerts, filter)
Expand All @@ -341,17 +428,23 @@ def test_filter_alerts_by_statuses():
assert len(filter_model_alerts) == 3
assert len(filter_malformed_alerts) == 0

filter = SelectorFilterSchema(statuses=[Status.FAIL, Status.WARN])
filter = SelectorFilterSchema(
statuses=[Status.FAIL, Status.WARN, Status.RUNTIME_ERROR]
)
filter_test_alerts = _filter_alerts_by_status(test_alerts, filter)
filter_model_alerts = _filter_alerts_by_status(model_alerts, filter)
filter_malformed_alerts = _filter_alerts_by_status(malformed_alerts, filter)
filter_source_freshness_alerts = _filter_alerts_by_status(
source_freshness_alerts, filter
)
assert len(filter_test_alerts) == 4
assert len(filter_model_alerts) == 0
assert len(filter_malformed_alerts) == 2
assert len(filter_source_freshness_alerts) == 2


def test_filter_alerts_by_resource_types():
test_alerts, model_alerts, malformed_alerts = initial_alerts()
test_alerts, model_alerts, malformed_alerts, _ = initial_alerts()
all_alerts = test_alerts + model_alerts + malformed_alerts

filter = SelectorFilterSchema(resource_types=[ResourceType.TEST])
Expand Down