Notify tests fails to slack #1082
Conversation
ELE-1158 open source daily test run fails - alert on slack
Definition of done: When the dbt-data-reliability daily run fails it'd send an alerts to slack to notify the failure |
|
👋 @noaKurman |
noaKurman
force-pushed
the
ele-1158-notify-tests-fails
branch
from
6413751
to
3bfcd64
Compare
noaKurman
force-pushed
the
ele-1158-notify-tests-fails
branch
2 times, most recently
from
19da411
to
cbcc3a2
Compare
|
General comment - I know there's code duplication here, which I might could have exported to a separated workflow, but then I'd need to use "wait for" which is much slower, so for now this feels good enough |
noaKurman
force-pushed
the
ele-1158-notify-tests-fails
branch
3 times, most recently
from
a7aa03e
to
ed0a32f
Compare
.github/workflows/notify_slack.yml
Outdated
| @@ -0,0 +1,39 @@ | |||
| name: Test all warehouse platforms | |||
| notify: | ||
| name: Notify Slack Failure | ||
| runs-on: ubuntu-latest | ||
| if: ${{ inputs.result == 'failure' }} |
There was a problem hiding this comment.
The caller should choose when to call this job.
If someone called Notify Slack it should run.
Would also change the name to be Notify Slack and not Notify Slack Failure to remain generic.
There was a problem hiding this comment.
I'm coloring the message, so if we'll want to add a "success" message we'll add another job with a different if statement. For now doesn't feel like a big deal in the implementation
There was a problem hiding this comment.
If you're not going to change it, then I think we should rename this workflow and step to notify_slack_failure and remove the if.
There was a problem hiding this comment.
But I might add a success job. thats what I'm saying
| with: | ||
| result: "failure" | ||
| run_id: ${{ github.run_id }} | ||
| workflow_name: "Test elementary GitHub action" |
There was a problem hiding this comment.
| workflow_name: "Test elementary GitHub action" | |
| workflow_name: "Test Elementary GitHub action" |
Forgive my OCD 😅
noaKurman
force-pushed
the
ele-1158-notify-tests-fails
branch
from
6c8cf74
to
0a7546f
Compare
No description provided.