Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELE-2390 - better logic separation for DataMonitoringAlerts flow #1384

Merged
merged 3 commits into from
Jan 23, 2024
Merged

ELE-2390 - better logic separation for DataMonitoringAlerts flow #1384

merged 3 commits into from
Jan 23, 2024

Conversation

IDoneShaveIt
Copy link
Contributor

@IDoneShaveIt IDoneShaveIt commented Jan 22, 2024 •
edited
Loading

  • Unified alerts' API and fetcher specific type methods
  • Split DataMonitoringAlerts flow into steps (populate, fetch, filter, format, skip, send)

@IDoneShaveIt
Unified alerts' API and fetcher specific type methods + split DataMon…
f22c185 
…itoringAlerts flow into steps (populate, fetch, filter, format, skip, send)
@linear Linear
Copy link

linear bot commented Jan 22, 2024

ELE-2390 Better logic separation for DataMonitoringAlerts flow

@github-actions GitHub Actions
Copy link
Contributor

👋 @IDoneShaveIt
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

IDoneShaveIt
IDoneShaveIt commented Jan 22, 2024
View reviewed changes
elementary/monitor/fetchers/alerts/schema/alert_data.py
Copy link
Contributor Author

@IDoneShaveIt IDoneShaveIt Jan 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was moved and wasn't changed at all!!!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NoyaArie

NoyaArie
NoyaArie approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@NoyaArie NoyaArie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IDoneShaveIt IDoneShaveIt merged commit f5f0b71 into master Jan 23, 2024
3 checks passed
@IDoneShaveIt IDoneShaveIt deleted the ele-2390-better-logic-separation-for-datamonitoringalerts-flow branch January 23, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoyaArie NoyaArie NoyaArie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IDoneShaveIt @NoyaArie