Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle None message for model alerts (skipped models) #1399

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Handle None message for model alerts (skipped models) #1399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion elementary/monitor/alerts/model_alert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ def __init__(
path: str,
original_path: str,
materialization: str,
message: str,
full_refresh: bool,
alert_class_id: str,
message: Optional[str] = None,
model_unique_id: Optional[str] = None,
detected_at: Optional[datetime] = None,
database_name: Optional[str] = None,
Expand Down
2 changes: 1 addition & 1 deletion elementary/monitor/fetchers/alerts/schema/alert_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ class ModelAlertDataSchema(BaseAlertDataSchema):
original_path: str
materialization: str
full_refresh: bool
message: str
message: Optional[str] = None
resource_type: ResourceType = Field(ResourceType.MODEL, const=True)

def format_alert(
Expand Down
Loading