Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent failing on missing full path #1402

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Prevent failing on missing full path #1402

merged 1 commit into from
Feb 7, 2024

Conversation

erikzaadi
Copy link
Contributor

Any artifact with an optional full_path should not fail schema

@linear Linear
Copy link

linear bot commented Feb 6, 2024

ELE-2469 Sentry bug: Split failed for full path

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

👋 @erikzaadi
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

IDoneShaveIt
IDoneShaveIt approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@IDoneShaveIt IDoneShaveIt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erikzaadi erikzaadi merged commit 061cfb1 into master Feb 7, 2024
3 checks passed
@erikzaadi erikzaadi deleted the ele-2469-sentry-bug-split-failed-for-full-path branch February 7, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IDoneShaveIt IDoneShaveIt IDoneShaveIt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikzaadi @IDoneShaveIt