Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr 1669 lock files #1753

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Pr 1669 lock files #1753

merged 4 commits into from
Nov 18, 2024

Conversation

haritamar
Copy link
Collaborator

@haritamar haritamar commented Nov 18, 2024

null

Copy link
Contributor

👋 @haritamar
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

dbt deps --lock --project-dir elementary/monitor/dbt_project && git diff --quiet elementary/monitor/dbt_project/package-lock.yml || (echo "Changes detected in package lock file!" && exit 1);
else
echo "Skipping hook, dbt version is $dbt_version (< 1.8).";
fi
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used chatgpt to generate this - basically verify that the lock is up to date, but only for dbt 1.8 and above (locks were introduced then)

@haritamar haritamar merged commit d32c132 into master Nov 18, 2024
4 checks passed
@haritamar haritamar deleted the pr-1669-lock-files branch November 18, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants