-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FormatBar: absorb line width guide settings #1237
base: master
Are you sure you want to change the base?
Conversation
Not sure about discoverabiity here - max line width seems unrelated to current line number and goto line number. I agree that as it a possible Removing it from the preferences menu seems inconsistent to what was done with indent-size and indent-type which are still there. |
Maybe together with the tab size and tab style? since they all are about code style. |
@danirabbit What do you think of @Marukesu 's idea? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uncertainties regarding appropriate location and discovery need addressing (see comments)
The The first task is to actually make the line-width guide settable per document and to follow the editorconfig setting in preference to the global app setting (like tab width). |
Converting to draft as there a unresolved questions regarding the design and groundwork needs doing. |
Move this setting to the FormatBar since people may want to adjust this per-file and can be overwritten by editorconfig.
In a future branch, set item sensitivity when overwritten by editorconfig