Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Implement zoom" #741

Closed
wants to merge 1 commit into from
Closed

Revert "Implement zoom" #741

wants to merge 1 commit into from

Conversation

lenemter
Copy link
Member

Reverts #739
Fixes #740

@ryonakano
Copy link
Contributor

This is an issue with debian packaging. We added the new io.elementary.greeter-compositor.gschema.xml file in the #739 but it's not included in the deb file, which results the null access here:

        var schema = new GLib.Settings ("io.elementary.greeter-compositor.keybindings");

        display.add_keybinding ("zoom-in", schema, Meta.KeyBindingFlags.NONE, (Meta.KeyHandlerFunc) zoom_in);
        display.add_keybinding ("zoom-out", schema, Meta.KeyBindingFlags.NONE, (Meta.KeyHandlerFunc) zoom_out);

@ryonakano
Copy link
Contributor

Closing because the linked issue should be fixed by 89dff87, but thank you for your quick response anyways, @lenemter!

@ryonakano ryonakano closed this Jun 24, 2024
@ryonakano ryonakano deleted the revert-739-lenemter/zoom branch June 24, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coredump and login screen is not shown
2 participants