Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to GTK 4 #749

Merged
merged 44 commits into from
Aug 6, 2024
Merged

Port to GTK 4 #749

merged 44 commits into from
Aug 6, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Feb 14, 2024

Fixes #628

@danirabbit
Copy link
Member Author

danirabbit commented Jun 6, 2024

Tested the constraint layout with a number of different partitions with small and large partitions on either end and with unused space:

Screenshot from 2024-06-06 16 59 15

@danirabbit danirabbit marked this pull request as ready for review June 20, 2024 00:10
@danirabbit danirabbit requested a review from a team June 20, 2024 00:10
@ryonakano
Copy link
Contributor

We also need to update the dependencies in README :)

@danirabbit
Copy link
Member Author

@ryonakano done!

@zeebok
Copy link
Contributor

zeebok commented Jul 28, 2024

Just tried testing this and noticed this missing icon?
Screenshot from 2024-07-27 20 28 06

EDIT: After updating my VM and grabbing gparted so I could test the partition view, it is showing up so maybe not a problem. The fact the gparted's UI is opening and partition view showing up, it may just be something with my VM environment.

Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing in the code sticks out, and running in test mode worked well except for some reason trying to modify partitions just opened gparted on my machine. But I assume that is just from me running it locally instead of in a normal live session or in VM

@danirabbit
Copy link
Member Author

@zeebok ah yeah "modify" always opens gparted. There's no partition resizing here. You can only choose what to apply on each partition but can't resize or create or delete partitions

@danirabbit danirabbit enabled auto-merge (squash) August 6, 2024 22:39
@danirabbit danirabbit merged commit 42f13cb into master Aug 6, 2024
3 of 5 checks passed
@danirabbit danirabbit deleted the danirabbit/gtk4 branch August 6, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port Installer to GTK4
3 participants