Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PartitionBar: cleanup and code style #751

Merged
merged 3 commits into from
Apr 29, 2024
Merged

PartitionBar: cleanup and code style #751

merged 3 commits into from
Apr 29, 2024

Conversation

danirabbit
Copy link
Member

  • Use Gtk.Gesture instead of EventBox with button press event
  • GObject style as much as possible
  • Reduce the number of public properties, especially since partition is already a construction property
  • Remove dead code
  • Add a simple icon property instead of other classes changing this classes widget children
  • clarify a couple property names
  • Code style

@danirabbit danirabbit requested a review from a team February 14, 2024 20:07
@danirabbit danirabbit enabled auto-merge (squash) April 29, 2024 16:49
@danirabbit danirabbit merged commit fcd8366 into master Apr 29, 2024
4 of 5 checks passed
@danirabbit danirabbit deleted the danirabbit/partitionbar-cleanup branch April 29, 2024 16:50
@vjr vjr mentioned this pull request May 4, 2024
Closed
danirabbit added a commit that referenced this pull request May 7, 2024
@danirabbit
Revert "PartitionBar: cleanup and code style (#751)"
da647eb 
This reverts commit fcd8366.
@danirabbit danirabbit mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
GTK4 Porting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @zeebok