Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application: modernize and set up locale #776

Merged
merged 2 commits into from
May 28, 2024
Merged

Application: modernize and set up locale #776

merged 2 commits into from
May 28, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented May 28, 2024 •
edited
Loading

fixes #775

Screenshot from 2024-05-27 18 46 37

Modernize application class:

  • Use built in way to load icons
  • Set up everything locale related we do in other apps
  • Set app ID and flags in object call
  • load disk bar CSS in startup not activate

@danirabbit danirabbit requested review from ryonakano and a team May 28, 2024 01:45
ryonakano
ryonakano reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, I'll test it when I get back home. Just leaving one comment

data/io.elementary.installer.gresource.xml Outdated Show resolved Hide resolved
@danirabbit danirabbit requested a review from ryonakano May 28, 2024 03:36
@danirabbit danirabbit merged commit 6e42c0d into master May 28, 2024
3 of 5 checks passed
@danirabbit danirabbit deleted the danirabbit/application-modernize branch May 28, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryonakano ryonakano ryonakano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
OS 8
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installer is not localized
2 participants
@danirabbit @ryonakano