Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the KeyboardLayout and KeyboardVariant handling #787

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit requested a review from tintou June 19, 2024 04:25
@danirabbit danirabbit force-pushed the danirabbit/refactor-keyboardlayoutvariant branch 2 times, most recently from 675421c to 0471ceb Compare June 19, 2024 04:37
Update to match latest Initial Setup

Fix missing testmode line

Add missing files

Fix extra semicolon
@danirabbit danirabbit force-pushed the danirabbit/refactor-keyboardlayoutvariant branch from 0471ceb to e40d5ac Compare June 19, 2024 04:39
@danirabbit
Copy link
Member Author

@tintou please feel free to fix the author information here. I tried to do it, but I think I messed it up pushing other commits

Copy link
Member

@tintou tintou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a glance, hard to really review such a big change though

@danirabbit danirabbit enabled auto-merge (squash) July 26, 2024 15:28
@danirabbit danirabbit merged commit df6300c into master Jul 26, 2024
3 of 5 checks passed
@danirabbit danirabbit deleted the danirabbit/refactor-keyboardlayoutvariant branch July 26, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants