Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set mnemonic widgets, keyboard focus in variant lists #791

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Set mnemonic widgets, keyboard focus in variant lists #791

merged 4 commits into from
Aug 12, 2024

Conversation

danirabbit
Copy link
Member

Essentially https://github.com/elementary/initial-setup/pull/176/files plus a couple fixes specific to here

  • Set mnemonic widgets that were missing so the screen reader knows how to label listboxes etc
  • Use CSS instead of markup to style listbox headers since markup is read in the screen reader like "less than b great than"
  • Set keyboard focus in the sub variant list box to improve keyboard workflow. Otherwise focus is set on back button which is weird

@danirabbit danirabbit requested a review from a team August 8, 2024 18:58
@danirabbit danirabbit enabled auto-merge (squash) August 12, 2024 18:35
@danirabbit danirabbit merged commit 5f4cb4d into main Aug 12, 2024
3 of 5 checks passed
@danirabbit danirabbit deleted the danirabbit/a11y-improvements branch August 12, 2024 18:36
@danirabbit danirabbit mentioned this pull request Sep 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A11y
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @zeebok