Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace width_chars with clamp #798

Merged
merged 6 commits into from
Sep 24, 2024
Merged

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Sep 11, 2024

Removes a max_width_chars hack and instead puts the content area in a clamp

@danirabbit danirabbit requested a review from a team September 11, 2024 20:42
@danirabbit danirabbit mentioned this pull request Sep 11, 2024
@ryonakano
Copy link
Contributor

Hmm for me the issue is still reproducible:

elementary.OS.8.Early.Access-screen0.webm

@danirabbit
Copy link
Member Author

Ah damn I wasn't able to reproduce at all in this branch 🤔 Is this under X11 or Wayland?

@alainm23
Copy link

alainm23 commented Sep 12, 2024

Perhaps you could use a Gtk.ScrolledWindow with vscrollbar_policy and hvscrollbar_policy in NEVER to prevent the label from expanding the parent container.

@danirabbit
Copy link
Member Author

@alainm23 yeah the partition bars are actually already inside a scrolled window. Will dig in further today though

@danirabbit danirabbit changed the title Fix expanding window Replace width_chars with clamp Sep 12, 2024
@ryonakano
Copy link
Contributor

Ah damn I wasn't able to reproduce at all in this branch 🤔 Is this under X11 or Wayland?

I'm on X11. Maybe it should make sure it works on X11 because the current Greeter runs on it.

@danirabbit
Copy link
Member Author

danirabbit commented Sep 23, 2024

@ryonakano even though this branch alone doesn't fix the issue it would still help to try to narrow down the cause by eliminating another potential problem. It might be a few different issues interacting. Same with the navigationview branch

Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed all texts in the all views are wrapped nicely both when the window is narrow and wide.

@danirabbit danirabbit merged commit 9302468 into main Sep 24, 2024
5 checks passed
@danirabbit danirabbit deleted the danirabbit/expandingwindowfix branch September 24, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants