-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace width_chars with clamp #798
Conversation
Hmm for me the issue is still reproducible: elementary.OS.8.Early.Access-screen0.webm |
Ah damn I wasn't able to reproduce at all in this branch 🤔 Is this under X11 or Wayland? |
Perhaps you could use a |
@alainm23 yeah the partition bars are actually already inside a scrolled window. Will dig in further today though |
I'm on X11. Maybe it should make sure it works on X11 because the current Greeter runs on it. |
@ryonakano even though this branch alone doesn't fix the issue it would still help to try to narrow down the cause by eliminating another potential problem. It might be a few different issues interacting. Same with the navigationview branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed all texts in the all views are wrapped nicely both when the window is narrow and wide.
Removes a max_width_chars hack and instead puts the content area in a clamp