Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiskBar: add constraint guide #816

Merged
merged 9 commits into from
Oct 13, 2024
Merged

DiskBar: add constraint guide #816

merged 9 commits into from
Oct 13, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Sep 25, 2024 •
edited
Loading

Fixes #793

ryonakano
ryonakano reviewed Sep 28, 2024
View reviewed changes
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installer crashes with malloc_consolidate(): unaligned fastbin chunk detected error when I re-entering the custom partition view:

screencast.mp4

@danirabbit danirabbit changed the title DiskBar: use constraint from constant instead of relative DiskBar: add constraint guide Oct 3, 2024
@danirabbit danirabbit requested a review from ryonakano October 3, 2024 19:07
@danirabbit
Copy link
Member Author

@ryonakano I think I finally did it! 🙏

ryonakano
ryonakano reviewed Oct 12, 2024
View reviewed changes
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late review, confirmed the issue seems to be resolved in the live ISO too. Leaving one small comment

VirtualBox_test_12_10_2024_11_01_15

src/Views/PartitioningView.vala Outdated Show resolved Hide resolved
@danirabbit danirabbit requested a review from ryonakano October 12, 2024 17:10
ryonakano
ryonakano approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this fix!

@danirabbit danirabbit enabled auto-merge (squash) October 13, 2024 23:26
@danirabbit
Copy link
Member Author

@ryonakano thanks for reviewing all the different branches I made trying to figure it out 😅

@danirabbit danirabbit merged commit cc3401b into main Oct 13, 2024
5 checks passed
@danirabbit danirabbit deleted the danirabbit/diskbar-constraintconst branch October 13, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryonakano ryonakano ryonakano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking a partition in the custom install glitches the installer window
2 participants
@danirabbit @ryonakano